[Checkins] SVN: z3c.recipe.eggbasket/trunk/ Windows compatibility fix.

Martijn Faassen faassen at infrae.com
Thu Jan 8 15:45:20 EST 2009


Log message for revision 94656:
  Windows compatibility fix.
  

Changed:
  U   z3c.recipe.eggbasket/trunk/CHANGES.txt
  U   z3c.recipe.eggbasket/trunk/z3c/recipe/eggbasket/downloader.py

-=-
Modified: z3c.recipe.eggbasket/trunk/CHANGES.txt
===================================================================
--- z3c.recipe.eggbasket/trunk/CHANGES.txt	2009-01-08 20:27:58 UTC (rev 94655)
+++ z3c.recipe.eggbasket/trunk/CHANGES.txt	2009-01-08 20:45:19 UTC (rev 94656)
@@ -1,7 +1,8 @@
 0.4.1 (unreleased)
 ==================
 
-* nothing changed yet
+* Windows compatibility fix: use ``'wb'`` for writing to make downloading
+  of the egg tarball succeeds on Windows.
 
 0.4.0 (2008-09-22)
 ==================

Modified: z3c.recipe.eggbasket/trunk/z3c/recipe/eggbasket/downloader.py
===================================================================
--- z3c.recipe.eggbasket/trunk/z3c/recipe/eggbasket/downloader.py	2009-01-08 20:27:58 UTC (rev 94655)
+++ z3c.recipe.eggbasket/trunk/z3c/recipe/eggbasket/downloader.py	2009-01-08 20:45:19 UTC (rev 94656)
@@ -43,7 +43,7 @@
                 extraction_dir = tempfile.mkdtemp()
                 filenum, temp_tarball_name = tempfile.mkstemp()
 
-                tarball = open(temp_tarball_name, 'w')
+                tarball = open(temp_tarball_name, 'wb')
                 try:
                     tarball.write(urllib.urlopen(url).read())
                 except IOError:



More information about the Checkins mailing list