[Checkins] SVN: grokcore.view/trunk/src/grokcore/view/ Reverted change to checkTemplates: back to the old situation

Reinout van Rees reinout at vanrees.org
Sat Jul 4 10:04:25 EDT 2009


Log message for revision 101524:
  Reverted change to checkTemplates: back to the old situation

Changed:
  U   grokcore.view/trunk/src/grokcore/view/interfaces.py
  U   grokcore.view/trunk/src/grokcore/view/meta/views.py

-=-
Modified: grokcore.view/trunk/src/grokcore/view/interfaces.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/interfaces.py	2009-07-04 13:26:26 UTC (rev 101523)
+++ grokcore.view/trunk/src/grokcore/view/interfaces.py	2009-07-04 14:04:25 UTC (rev 101524)
@@ -19,6 +19,7 @@
 
 class IBaseClasses(Interface):
     View = Attribute("Base class for browser views.")
+    CodeView = Attribute("Base class for browser views with render().")
     DirectoryResource = Attribute("Base class to create new "
                                   "directory resource.")
 

Modified: grokcore.view/trunk/src/grokcore/view/meta/views.py
===================================================================
--- grokcore.view/trunk/src/grokcore/view/meta/views.py	2009-07-04 13:26:26 UTC (rev 101523)
+++ grokcore.view/trunk/src/grokcore/view/meta/views.py	2009-07-04 14:04:25 UTC (rev 101524)
@@ -81,15 +81,15 @@
         return True
 
 
-    # CHECK THIS.  There is no template/render checking anymore, so this is a bit
-    # elaborate.
     def checkTemplates(self, templates, module_info, factory):
 
         def has_render(factory):
-	    return False
+            render = getattr(factory, 'render', None)
+            base_method = getattr(render, 'base_method', False)
+            return render and not base_method
 
         def has_no_render(factory):
-	    return True
+            return not getattr(factory, 'render', None)
         templates.checkTemplates(module_info, factory, 'view',
                                  has_render, has_no_render)
 



More information about the Checkins mailing list