[Checkins] SVN: zope.fssync/trunk/src/zope/fssync/tests/ Try fixing test for release.

Fred Drake fdrake at gmail.com
Fri Jul 24 13:14:30 EDT 2009


On Fri, Jul 24, 2009 at 1:05 PM, Stephan Richter<srichter at gmail.com> wrote:
> +TESTDIR = os.path.join(os.path.dirname(__file__), 'svntestdir')
...
> +    if not os.path.exists(TESTDIR):
> +        os.mkdir(TESTDIR)

This might be better than it was, but creating a directory that tests
can write to within the package is a bad idea.  Is there really any
reason not to use tempfile.mkdtemp for this?


  -Fred

-- 
Fred L. Drake, Jr.    <fdrake at gmail.com>
"Chaos is the score upon which reality is written." --Henry Miller


More information about the Checkins mailing list