[Checkins] SVN: zc.buildout/branches/tlotze-download-api/src/zc/buildout/download. fixed a TypeError raised when checking the MD5 sum of a local resource, provided a test for the concerned code path

Thomas Lotze tl at gocept.com
Mon Jun 22 15:02:06 EDT 2009


Log message for revision 101234:
  fixed a TypeError raised when checking the MD5 sum of a local resource, provided a test for the concerned code path

Changed:
  U   zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.py
  U   zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.txt

-=-
Modified: zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.py
===================================================================
--- zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.py	2009-06-22 18:59:19 UTC (rev 101233)
+++ zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.py	2009-06-22 19:02:06 UTC (rev 101234)
@@ -144,7 +144,7 @@
         parsed_url = urlparse.urlparse(url, 'file')
         if parsed_url.scheme == 'file':
             self.logger.debug('Using local resource %s' % url)
-            if not check_md5sum(path, md5sum):
+            if not check_md5sum(parsed_url.path, md5sum):
                 raise ChecksumError(
                     'MD5 checksum mismatch for local resource at %r.' %
                     parsed_url.path)

Modified: zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.txt
===================================================================
--- zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.txt	2009-06-22 18:59:19 UTC (rev 101233)
+++ zc.buildout/branches/tlotze-download-api/src/zc/buildout/download.txt	2009-06-22 19:02:06 UTC (rev 101234)
@@ -60,6 +60,17 @@
 Traceback (most recent call last):
 ChecksumError: MD5 checksum mismatch downloading 'http://localhost/foo.txt'
 
+The error message in the event of an MD5 checksum mismatch for a local file
+reads somewhat differently:
+
+>>> path = download(join(server_data, 'foo.txt'),
+...                 md5('This is a foo text.').hexdigest())
+
+>>> path = download(join(server_data, 'foo.txt'),
+...                 md5('The wrong text.').hexdigest())
+Traceback (most recent call last):
+ChecksumError: MD5 checksum mismatch for local resource at '/sample_files/foo.txt'.
+
 Finally, we can download the file to a specified place in the file system:
 
 >>> target_dir = tmpdir('download-target')



More information about the Checkins mailing list