[Checkins] SVN: zope.app.testing/trunk/ Use ISkinnable.providedBy(request) instead of IBrowserRequest as condition
Roger Ineichen
roger at projekt01.ch
Mon Mar 9 21:19:59 EDT 2009
Log message for revision 97753:
Use ISkinnable.providedBy(request) instead of IBrowserRequest as condition
for calling setDefaultSkin in HTTPCaller. This at the same time removes
dependency to the browser part of zope.publisher.
Changed:
U zope.app.testing/trunk/CHANGES.txt
U zope.app.testing/trunk/src/zope/app/testing/functional.py
-=-
Modified: zope.app.testing/trunk/CHANGES.txt
===================================================================
--- zope.app.testing/trunk/CHANGES.txt 2009-03-10 01:14:59 UTC (rev 97752)
+++ zope.app.testing/trunk/CHANGES.txt 2009-03-10 01:19:59 UTC (rev 97753)
@@ -5,6 +5,10 @@
3.6.1 (unreleased)
------------------
+- Use ISkinnable.providedBy(request) instead of IBrowserRequest as condition
+ for calling setDefaultSkin in HTTPCaller. This at the same time removes
+ dependency to the browser part of zope.publisher.
+
- Adapt to the move of IDefaultViewName from zope.component.interfaces
to zope.publisher.interfaces.
Modified: zope.app.testing/trunk/src/zope/app/testing/functional.py
===================================================================
--- zope.app.testing/trunk/src/zope/app/testing/functional.py 2009-03-10 01:14:59 UTC (rev 97752)
+++ zope.app.testing/trunk/src/zope/app/testing/functional.py 2009-03-10 01:19:59 UTC (rev 97753)
@@ -33,9 +33,11 @@
from ZODB.interfaces import IDatabase
from zope import component
-from zope.publisher.browser import BrowserRequest, setDefaultSkin
+from zope.publisher.interfaces import ISkinnable
+from zope.publisher.browser import BrowserRequest
from zope.publisher.http import HTTPRequest
from zope.publisher.publish import publish
+from zope.publisher.skinnable import setDefaultSkin
from zope.security.interfaces import Forbidden, Unauthorized
from zope.testing import doctest
@@ -47,7 +49,6 @@
from zope.app.publication.zopepublication import ZopePublication
from zope.app.publication.http import HTTPPublication
from zope.app.publication.httpfactory import chooseClasses
-from zope.publisher.interfaces.browser import IBrowserRequest
from zope.site.hooks import setSite, getSite
class ResponseWrapper(object):
@@ -730,8 +731,8 @@
path, instream,
environment=environment,
request=request_cls, publication=publication_cls)
- if IBrowserRequest.providedBy(request):
- # only browser requests have skins
+ if ISkinnable.providedBy(request):
+ # only ISkinnable requests have skins
setDefaultSkin(request)
if form is not None:
More information about the Checkins
mailing list