[Checkins] SVN: zc.buildout/branches/help-api/ - Quote the 'executable' argument when trying to detect the python version using popen4.

Godefroid Chapelle gotcha at bubblenet.be
Sun Mar 29 17:19:09 EDT 2009


Log message for revision 98486:
   - Quote the 'executable' argument when trying to detect the python version using popen4.

Changed:
  U   zc.buildout/branches/help-api/CHANGES.txt
  U   zc.buildout/branches/help-api/src/zc/buildout/easy_install.py

-=-
Modified: zc.buildout/branches/help-api/CHANGES.txt
===================================================================
--- zc.buildout/branches/help-api/CHANGES.txt	2009-03-29 21:19:02 UTC (rev 98485)
+++ zc.buildout/branches/help-api/CHANGES.txt	2009-03-29 21:19:09 UTC (rev 98486)
@@ -7,6 +7,9 @@
 1.0.4 (unreleased)
 ==================
 
+- Quote the 'executable' argument when trying to detect the python 
+  version using popen4. (sidnei)
+
 - Quote the 'spec' argument, as in the case of installing an egg from
   the buildout-cache, if the filename contains spaces it would fail (sidnei)
 

Modified: zc.buildout/branches/help-api/src/zc/buildout/easy_install.py
===================================================================
--- zc.buildout/branches/help-api/src/zc/buildout/easy_install.py	2009-03-29 21:19:02 UTC (rev 98485)
+++ zc.buildout/branches/help-api/src/zc/buildout/easy_install.py	2009-03-29 21:19:09 UTC (rev 98486)
@@ -61,7 +61,7 @@
     try:
         return _versions[executable]
     except KeyError:
-        i, o = os.popen4(executable + ' -V')
+        i, o = os.popen4(_safe_arg(executable) + ' -V')
         i.close()
         version = o.read().strip()
         o.close()



More information about the Checkins mailing list