[Checkins] SVN: Products.GenericSetup/branches/1.4/Products/GenericSetup/ make sure that creating a snapshot through the ZMI doesn't hang indefinitely

David Glick davidglick at onenw.org
Fri May 15 13:49:18 EDT 2009


Log message for revision 99981:
  make sure that creating a snapshot through the ZMI doesn't hang indefinitely

Changed:
  U   Products.GenericSetup/branches/1.4/Products/GenericSetup/CHANGES.txt
  U   Products.GenericSetup/branches/1.4/Products/GenericSetup/tool.py

-=-
Modified: Products.GenericSetup/branches/1.4/Products/GenericSetup/CHANGES.txt
===================================================================
--- Products.GenericSetup/branches/1.4/Products/GenericSetup/CHANGES.txt	2009-05-15 14:10:38 UTC (rev 99980)
+++ Products.GenericSetup/branches/1.4/Products/GenericSetup/CHANGES.txt	2009-05-15 17:49:17 UTC (rev 99981)
@@ -4,7 +4,8 @@
 1.4.4 (unreleased)
 ------------------
 
-- TBD
+- Make sure that manage_createSnapshot returns something to the browser when
+  it's done. (http://dev.plone.org/plone/ticket/8452)
 
 1.4.3 (2009-04-22)
 ------------------

Modified: Products.GenericSetup/branches/1.4/Products/GenericSetup/tool.py
===================================================================
--- Products.GenericSetup/branches/1.4/Products/GenericSetup/tool.py	2009-05-15 14:10:38 UTC (rev 99980)
+++ Products.GenericSetup/branches/1.4/Products/GenericSetup/tool.py	2009-05-15 17:49:17 UTC (rev 99981)
@@ -790,9 +790,8 @@
 
         self.createSnapshot(snapshot_id)
 
-        RESPONSE.redirect('%s/manage_snapshots?manage_tabs_message=%s'
+        return RESPONSE.redirect('%s/manage_snapshots?manage_tabs_message=%s'
                          % (self.absolute_url(), 'Snapshot+created.'))
-        return ""
 
     security.declareProtected(ManagePortal, 'manage_showDiff')
     manage_showDiff = PageTemplateFile('sutCompare', _wwwdir)



More information about the Checkins mailing list