[Checkins] SVN: z3c.saconfig/trunk/ engine.echo must default to None for logging module

Daniel Holth dholth at gmail.com
Mon Nov 16 11:20:04 EST 2009


Log message for revision 105722:
  engine.echo must default to None for logging module
  

Changed:
  U   z3c.saconfig/trunk/CHANGES.txt
  U   z3c.saconfig/trunk/src/z3c/saconfig/zcml.py

-=-
Modified: z3c.saconfig/trunk/CHANGES.txt
===================================================================
--- z3c.saconfig/trunk/CHANGES.txt	2009-11-16 15:42:36 UTC (rev 105721)
+++ z3c.saconfig/trunk/CHANGES.txt	2009-11-16 16:20:03 UTC (rev 105722)
@@ -4,7 +4,8 @@
 0.9.2 (unreleased)
 ==================
 
-- Nothing changed yet.
+- engine.echo must default to None for SQLAlchemy to honor
+  logging.getLogger("sqlalchemy.engine").setLevel(...)
 
 
 0.9.1 (2009-08-14)

Modified: z3c.saconfig/trunk/src/z3c/saconfig/zcml.py
===================================================================
--- z3c.saconfig/trunk/src/z3c/saconfig/zcml.py	2009-11-16 15:42:36 UTC (rev 105721)
+++ z3c.saconfig/trunk/src/z3c/saconfig/zcml.py	2009-11-16 16:20:03 UTC (rev 105722)
@@ -33,7 +33,7 @@
         title=u'Echo SQL statements',
         description=u'Enable logging statements for debugging.',
         required=False,
-        default=False)
+        default=None)
     
     setup = zope.schema.BytesLine(
         title=u'After engine creation hook',
@@ -70,7 +70,7 @@
         default="z3c.saconfig.utility.GloballyScopedSession")
 
 
-def engine(_context, url, name=u"", convert_unicode=False, echo=False, setup=None, twophase=False):
+def engine(_context, url, name=u"", convert_unicode=False, echo=None, setup=None, twophase=False):
     factory = utility.EngineFactory(
         url, echo=echo, convert_unicode=convert_unicode)
     



More information about the checkins mailing list