[Checkins] SVN: zope.testing/branches/regebro-python3/src/zope/testing/testrunner/runner.py fix a typo (missing variable)

Wolfgang Schnerring wosc at wosc.de
Sun Sep 13 04:28:45 EDT 2009


Log message for revision 103881:
  fix a typo (missing variable)
  
  This branch of the code does not seem to be covered by our normal tests but showed up when running tests with py3 by accident.
  

Changed:
  U   zope.testing/branches/regebro-python3/src/zope/testing/testrunner/runner.py

-=-
Modified: zope.testing/branches/regebro-python3/src/zope/testing/testrunner/runner.py
===================================================================
--- zope.testing/branches/regebro-python3/src/zope/testing/testrunner/runner.py	2009-09-13 08:26:59 UTC (rev 103880)
+++ zope.testing/branches/regebro-python3/src/zope/testing/testrunner/runner.py	2009-09-13 08:28:45 UTC (rev 103881)
@@ -438,7 +438,8 @@
                 break
 
         # Now stderr should be ready to read the whole thing.
-        erriter = iter(child.stderr.read().splitlines())
+        suberr = child.stderr.read()
+        erriter = iter(suberr.splitlines())
         nfail = nerr = 0
         for line in erriter:
             try:
@@ -448,6 +449,7 @@
             else:
                 break
         else:
+            # XXX This code path is untested
             output = options.output
             output.error_with_banner("Could not communicate with subprocess:\n"
                                      "\n" + suberr)



More information about the checkins mailing list