[Checkins] SVN: grokcore.security/trunk/ Change the decision to use grok.View as the default permission for views and use the more "standard" zope.View permission instead.

[Jan-Wijbrand Kolman]

Log message for revision 103923:
  Change the decision to use grok.View as the default permission for views and use the more "standard" zope.View permission instead.

Changed:
  U   grokcore.security/trunk/CHANGES.txt
  U   grokcore.security/trunk/src/grokcore/security/meta.zcml
  U   grokcore.security/trunk/src/grokcore/security/testing.py
  U   grokcore.security/trunk/src/grokcore/security/tests/security/fallback.py
  U   grokcore.security/trunk/src/grokcore/security/util.py

-=-
Modified: grokcore.security/trunk/CHANGES.txt
===================================================================
--- grokcore.security/trunk/CHANGES.txt	2009-09-14 14:16:44 UTC (rev 103922)
+++ grokcore.security/trunk/CHANGES.txt	2009-09-14 14:44:34 UTC (rev 103923)
@@ -4,6 +4,17 @@
 1.2 (unreleased)
 ----------------
 
+* Changed the default permissions from grok.View to zope.View. There seems no
+  particular reason not to use the standard zope.View permission defined
+  in zope.app.security.
+
+  NOTE: YOU MUST STILL ASSIGN THIS PERMISSION TO USERS IN YOUR
+  site.zcml FILE. OTHERWISE YOU DO NOT HAVE ACCESS TO ANY VIEWS.
+
+* Made sure to include zope.app.security configuration as well, as that
+  package defines the zope.View permission. Note that in the future this will
+  change to zope.security.
+
 * Bring versions.cfg in line with grok 1.0 release candidate
   versions.cfg.
 
@@ -13,7 +24,7 @@
 
 * Changed the default permissions from zope.Public to grok.View.
 
-  NOTE: YOU MUST ASSIGN THIS PERMISSION TO USERS IN YOUR 
+  NOTE: YOU MUST ASSIGN THIS PERMISSION TO USERS IN YOUR
   site.zcml FILE. OTHERWISE YOU DO NOT HAVE ACCESS TO ANY VIEWS.
 
 1.0 (2008-08-03)

Modified: grokcore.security/trunk/src/grokcore/security/meta.zcml
===================================================================
--- grokcore.security/trunk/src/grokcore/security/meta.zcml	2009-09-14 14:16:44 UTC (rev 103922)
+++ grokcore.security/trunk/src/grokcore/security/meta.zcml	2009-09-14 14:44:34 UTC (rev 103923)
@@ -6,7 +6,4 @@
   <include package="grokcore.component" file="meta.zcml" />
   <grok:grok package=".meta" />
 
-  <!-- Grok my default permission -->
-  <grok:grok package=".default_permission" />
-
 </configure>

Modified: grokcore.security/trunk/src/grokcore/security/testing.py
===================================================================
--- grokcore.security/trunk/src/grokcore/security/testing.py	2009-09-14 14:16:44 UTC (rev 103922)
+++ grokcore.security/trunk/src/grokcore/security/testing.py	2009-09-14 14:44:34 UTC (rev 103923)
@@ -39,6 +39,5 @@
     zcml.do_grok('grokcore.component.meta', config)
     zcml.do_grok('grokcore.security.meta', config)
     zcml.do_grok('grokcore.security.testing', config)
-    zcml.do_grok('grokcore.security.default_permission', config)
     zcml.do_grok(module_name, config)
     config.execute_actions()

Modified: grokcore.security/trunk/src/grokcore/security/tests/security/fallback.py
===================================================================
--- grokcore.security/trunk/src/grokcore/security/tests/security/fallback.py	2009-09-14 14:16:44 UTC (rev 103922)
+++ grokcore.security/trunk/src/grokcore/security/tests/security/fallback.py	2009-09-14 14:44:34 UTC (rev 103923)
@@ -9,7 +9,7 @@
   >>> obj = ProxyFactory(obj)
   >>> checker = getChecker(obj)
   >>> checker.permission_id('protected')
-  'grok.View'
+  'zope.View'
 """
 import grokcore.security as grok
 

Modified: grokcore.security/trunk/src/grokcore/security/util.py
===================================================================
--- grokcore.security/trunk/src/grokcore/security/util.py	2009-09-14 14:16:44 UTC (rev 103922)
+++ grokcore.security/trunk/src/grokcore/security/util.py	2009-09-14 14:44:34 UTC (rev 103923)
@@ -36,11 +36,11 @@
     protectSetAttribute(class_, name, permission)
 
 def check_or_default_permission(class_, permission):
-    """Return default permission (public) if permission is None,
+    """Return default permission (zope.View) if permission is None,
     otherwise make sure permission has been defined.
     """
     if permission is None:
-        permission = 'grok.View'
+        permission = 'zope.View'
     else:
         check_permission(class_, permission)
     return permission