[Checkins] SVN: Products.PluggableAuthService/trunk/ Allow CookieAuthHelper's login_path to be set to an absolute url for integration with external authentication mechanisms.

Laurence Rowe l at lrowe.co.uk
Tue Apr 6 21:11:14 EDT 2010


Log message for revision 110576:
  Allow CookieAuthHelper's login_path to be set to an absolute url for integration with external authentication mechanisms.

Changed:
  U   Products.PluggableAuthService/trunk/CHANGES.txt
  U   Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py

-=-
Modified: Products.PluggableAuthService/trunk/CHANGES.txt
===================================================================
--- Products.PluggableAuthService/trunk/CHANGES.txt	2010-04-07 00:02:30 UTC (rev 110575)
+++ Products.PluggableAuthService/trunk/CHANGES.txt	2010-04-07 01:11:14 UTC (rev 110576)
@@ -4,6 +4,9 @@
 1.7.0 (unreleased)
 ------------------
 
+- Allow CookieAuthHelper's login_path to be set to an absolute url for
+  integration with external authentication mechanisms.
+
 - Fixed xml templates directory path computation to allow reuse of 
   ``SimpleXMLExportImport`` class outside ``Products.PluggableAuthService``.
 

Modified: Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py
===================================================================
--- Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py	2010-04-07 00:02:30 UTC (rev 110575)
+++ Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py	2010-04-07 01:11:14 UTC (rev 110576)
@@ -218,7 +218,7 @@
     security.declarePrivate('getLoginURL')
     def getLoginURL(self):
         """ Where to send people for logging in """
-        if self.login_path.startswith('/'):
+        if self.login_path.startswith('/') or '://' in self.login_path:
             return self.login_path
         elif self.login_path != '':
             return '%s/%s' % (self.absolute_url(), self.login_path)



More information about the checkins mailing list