[Checkins] SVN: relstorage/trunk/relstorage/adapters/locker.py cx_Oracle contradicts its documentation: callfunc does not seem to support keyword parameters after all.

Shane Hathaway shane at hathawaymix.org
Mon Apr 12 15:51:03 EDT 2010


Log message for revision 110763:
  cx_Oracle contradicts its documentation: callfunc does not seem to support keyword parameters after all.
  

Changed:
  U   relstorage/trunk/relstorage/adapters/locker.py

-=-
Modified: relstorage/trunk/relstorage/adapters/locker.py
===================================================================
--- relstorage/trunk/relstorage/adapters/locker.py	2010-04-12 19:36:44 UTC (rev 110762)
+++ relstorage/trunk/relstorage/adapters/locker.py	2010-04-12 19:51:03 UTC (rev 110763)
@@ -137,13 +137,12 @@
         # (for as short a time as possible).
         status = cursor.callfunc(
             "DBMS_LOCK.REQUEST",
-            self.inputsize_NUMBER,
-            keywordParameters={
-                'id': self.commit_lock_id,
-                'lockmode': 6,  # exclusive (X_MODE)
-                'timeout': self.commit_lock_timeout,
-                'release_on_commit': True,
-            })
+            self.inputsize_NUMBER, (
+                self.commit_lock_id,
+                6,  # exclusive (X_MODE)
+                self.commit_lock_timeout,
+                True,
+            ))
         if status != 0:
             if status >= 1 and status <= 5:
                 msg = ('', 'timeout', 'deadlock', 'parameter error',



More information about the checkins mailing list