[Checkins] SVN: Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py Fixed my fix of earlier today in CookieAuthHelper.extractCredentials by making sure we do not return a half filled dictionary when the password decode fails.

Maurits van Rees m.van.rees at zestsoftware.nl
Thu Aug 12 15:48:31 EDT 2010


Log message for revision 115658:
  Fixed my fix of earlier today in CookieAuthHelper.extractCredentials by making sure we do not return a half filled dictionary when the password decode fails.

Changed:
  U   Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py

-=-
Modified: Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py
===================================================================
--- Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py	2010-08-12 19:14:38 UTC (rev 115657)
+++ Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/CookieAuthHelper.py	2010-08-12 19:48:31 UTC (rev 115658)
@@ -129,7 +129,7 @@
                 creds['password'] = password.decode('hex')
             except TypeError:
                 # Cookie is in a different format, so it is not ours
-                return creds
+                return {}
 
         if creds:
             creds['remote_host'] = request.get('REMOTE_HOST', '')



More information about the checkins mailing list