[Checkins] SVN: Sandbox/ulif/grokui.zodbbrowser/src/grokui/zodbbrowser/pages.py Flash messages work again. Tell users about invalid OIDs.

Uli Fouquet uli at gnufix.de
Sat Mar 6 08:57:52 EST 2010


Log message for revision 109699:
  Flash messages work again. Tell users about invalid OIDs.
  

Changed:
  U   Sandbox/ulif/grokui.zodbbrowser/src/grokui/zodbbrowser/pages.py

-=-
Modified: Sandbox/ulif/grokui.zodbbrowser/src/grokui/zodbbrowser/pages.py
===================================================================
--- Sandbox/ulif/grokui.zodbbrowser/src/grokui/zodbbrowser/pages.py	2010-03-06 08:28:42 UTC (rev 109698)
+++ Sandbox/ulif/grokui.zodbbrowser/src/grokui/zodbbrowser/pages.py	2010-03-06 13:57:51 UTC (rev 109699)
@@ -32,13 +32,19 @@
         if oid is None:
             self.obj = self.context.root
         if self.obj is None:
-            oid = p64(int(self.request.get('oid', self.getRootOID()), 0))
+            try:
+                oid = p64(int(self.request.get('oid', self.getRootOID()), 0))
+            except ValueError:
+                # Invalid number sent
+                self.flash(
+                    u'Not a valid object ID: %s' % self.request.get('oid'))
+                self.redirect(self.url(self.context, '@@zodbbrowser'))
+                return
             jar = self.jar()
             try:
                 self.obj = jar.get(oid)
             except POSKeyError:
-                # This doesn't work currently...
-                #self.flash(u'OID not found: %s', oid)
+                self.flash(u'No such object ID: %s' % u64(oid))
                 self.redirect(self.url(self.context, '@@zodbbrowser'))
                 return
 



More information about the checkins mailing list