[Checkins] SVN: zope.exceptions/trunk/ zope.testing.CleanUp was used as a base for the test class, but no cleanup was ever performed, so I removed this dependency, as it makes the dependency graph circular for testing.

Lennart Regebro regebro at gmail.com
Sun May 2 13:27:46 EDT 2010


Log message for revision 111872:
  zope.testing.CleanUp was used as a base for the test class, but no cleanup was ever performed, so I removed this dependency, as it makes the dependency graph circular for testing.
  

Changed:
  U   zope.exceptions/trunk/CHANGES.txt
  U   zope.exceptions/trunk/setup.py
  U   zope.exceptions/trunk/src/zope/exceptions/tests/test_exceptionformatter.py

-=-
Modified: zope.exceptions/trunk/CHANGES.txt
===================================================================
--- zope.exceptions/trunk/CHANGES.txt	2010-05-02 17:19:14 UTC (rev 111871)
+++ zope.exceptions/trunk/CHANGES.txt	2010-05-02 17:27:45 UTC (rev 111872)
@@ -9,7 +9,10 @@
 
 - Added Python 3 support.
 
+- The dependency on zope.testing seemed spurious, possibly a rest of a real
+  dependency that is gone now. I removed it.
 
+
 3.5.2 (2008-04-30)
 ------------------
 

Modified: zope.exceptions/trunk/setup.py
===================================================================
--- zope.exceptions/trunk/setup.py	2010-05-02 17:19:14 UTC (rev 111871)
+++ zope.exceptions/trunk/setup.py	2010-05-02 17:27:45 UTC (rev 111872)
@@ -69,13 +69,9 @@
       packages=find_packages('src'),
       package_dir = {'': 'src'},
       namespace_packages=['zope'],
-      extras_require = dict(
-          test=['zope.testing'],
-          ),
       install_requires=['setuptools',
                         'zope.interface',
                        ],
-      tests_require=['zope.testing'],
       test_suite = 'zope.exceptions.tests',
       include_package_data = True,
       zip_safe = False,

Modified: zope.exceptions/trunk/src/zope/exceptions/tests/test_exceptionformatter.py
===================================================================
--- zope.exceptions/trunk/src/zope/exceptions/tests/test_exceptionformatter.py	2010-05-02 17:19:14 UTC (rev 111871)
+++ zope.exceptions/trunk/src/zope/exceptions/tests/test_exceptionformatter.py	2010-05-02 17:27:45 UTC (rev 111872)
@@ -19,7 +19,6 @@
 from unittest import TestCase, main, makeSuite
 
 from zope.exceptions.exceptionformatter import format_exception
-from zope.testing.cleanup import CleanUp # Base class w registry cleanup
 
 def tb(as_html=0):
     t, v, b = sys.exc_info()
@@ -46,7 +45,7 @@
 
 
 
-class Test(CleanUp, TestCase):
+class Test(TestCase):
 
     def testBasicNamesText(self, as_html=0):
         try:



More information about the checkins mailing list