[Checkins] SVN: z3c.form/trunk/src/z3c/form/ Fix a few pyflakes warnings. There are a lot more, but I'll leave those for others

Wichert Akkerman wichert at wiggy.net
Mon May 10 11:11:04 EDT 2010


Log message for revision 112226:
  Fix a few pyflakes warnings. There are a lot more, but I'll leave those for others

Changed:
  U   z3c.form/trunk/src/z3c/form/converter.py
  U   z3c.form/trunk/src/z3c/form/field.py
  U   z3c.form/trunk/src/z3c/form/object.py

-=-
Modified: z3c.form/trunk/src/z3c/form/converter.py
===================================================================
--- z3c.form/trunk/src/z3c/form/converter.py	2010-05-10 15:03:42 UTC (rev 112225)
+++ z3c.form/trunk/src/z3c/form/converter.py	2010-05-10 15:11:04 UTC (rev 112226)
@@ -114,7 +114,7 @@
             return self.field.missing_value
         try:
             return self.formatter.parse(value)
-        except zope.i18n.format.NumberParseError, err:
+        except zope.i18n.format.NumberParseError:
             raise FormatterValidationError(self.errorMessage, value)
 
 class IntegerDataConverter(NumberDataConverter):
@@ -265,7 +265,7 @@
         terms = widget.updateTerms()
         try:
             return [terms.getTerm(value).token]
-        except LookupError, err:
+        except LookupError:
             # Swallow lookup errors, in case the options changed.
             return []
 
@@ -274,7 +274,7 @@
         widget = self.widget
         if not len(value) or value[0] == widget.noValueToken:
             return self.field.missing_value
-        terms = widget.updateTerms()
+        widget.updateTerms()
         return widget.terms.getValue(value[0])
 
 
@@ -326,7 +326,6 @@
 
     def toFieldValue(self, value):
         """See interfaces.IDataConverter"""
-        widget = self.widget
         collectionType = self.field._type
         if isinstance(collectionType, tuple):
             collectionType = collectionType[-1]

Modified: z3c.form/trunk/src/z3c/form/field.py
===================================================================
--- z3c.form/trunk/src/z3c/form/field.py	2010-05-10 15:03:42 UTC (rev 112225)
+++ z3c.form/trunk/src/z3c/form/field.py	2010-05-10 15:11:04 UTC (rev 112226)
@@ -161,7 +161,6 @@
         assert len(kwargs) == 0
         if prefix:
             names = [util.expandPrefix(prefix) + name for name in names]
-        fields = [field for field in self.values()]
         return self.__class__(
             *[field for name, field in self.items()
               if not ((name in names and interface is None) or

Modified: z3c.form/trunk/src/z3c/form/object.py
===================================================================
--- z3c.form/trunk/src/z3c/form/object.py	2010-05-10 15:03:42 UTC (rev 112225)
+++ z3c.form/trunk/src/z3c/form/object.py	2010-05-10 15:11:04 UTC (rev 112226)
@@ -229,7 +229,7 @@
                 interfaces.IValidator).validate(value)
 
             widget.value = converter.toWidgetValue(value)
-        except (zope.schema.ValidationError, ValueError), error:
+        except (zope.schema.ValidationError, ValueError):
             # on exception, setup the widget error message
             # set the wrong value as value
             # the widget itself ought to cry about the error



More information about the checkins mailing list