[Checkins] SVN: z3c.form/trunk/src/z3c/form/form.py Improve change test

Wichert Akkerman wichert at wiggy.net
Mon May 10 11:19:00 EDT 2010


Log message for revision 112227:
  Improve change test

Changed:
  U   z3c.form/trunk/src/z3c/form/form.py

-=-
Modified: z3c.form/trunk/src/z3c/form/form.py
===================================================================
--- z3c.form/trunk/src/z3c/form/form.py	2010-05-10 15:11:04 UTC (rev 112226)
+++ z3c.form/trunk/src/z3c/form/form.py	2010-05-10 15:19:00 UTC (rev 112227)
@@ -44,9 +44,11 @@
         dm = zope.component.getMultiAdapter(
             (content, field.field), interfaces.IDataManager)
         # Only update the data, if it is different
+        # Or we can not get the original value, in which case we can not check
         # Or it is an Object, in case we'll never know
-        if ((dm.canAccess() and dm.get() != data[name])
-            or zope.schema.interfaces.IObject.providedBy(field.field)):
+        if (not dm.canAccess() or 
+            dm.get() != data[name] or 
+            zope.schema.interfaces.IObject.providedBy(field.field)):
             dm.set(data[name])
             # Record the change using information required later
             changes.setdefault(dm.field.interface, []).append(name)



More information about the checkins mailing list