[Checkins] SVN: zc.async/trunk/src/zc/async/ fix undefined variables too insidious for pyflakes to detect

Patrick Strawderman patrick at zope.com
Wed Sep 1 10:07:46 EDT 2010


Log message for revision 116091:
  fix undefined variables too insidious for pyflakes to detect

Changed:
  U   zc.async/trunk/src/zc/async/CHANGES.txt
  U   zc.async/trunk/src/zc/async/dispatcher.py
  U   zc.async/trunk/src/zc/async/utils.py

-=-
Modified: zc.async/trunk/src/zc/async/CHANGES.txt
===================================================================
--- zc.async/trunk/src/zc/async/CHANGES.txt	2010-09-01 13:52:38 UTC (rev 116090)
+++ zc.async/trunk/src/zc/async/CHANGES.txt	2010-09-01 14:07:46 UTC (rev 116091)
@@ -15,7 +15,10 @@
   Twisted's recalcitrance when it comes to stopping and subsequently
   starting a reactor instance.
 
+- Fix two undefined variables that could trigger exceptions in corner
+  cases.
 
+
 1.5.3 (2009-11-15)
 ==================
 

Modified: zc.async/trunk/src/zc/async/dispatcher.py
===================================================================
--- zc.async/trunk/src/zc/async/dispatcher.py	2010-09-01 13:52:38 UTC (rev 116090)
+++ zc.async/trunk/src/zc/async/dispatcher.py	2010-09-01 14:07:46 UTC (rev 116091)
@@ -683,7 +683,7 @@
             stat_start = first_poll.utc_timestamp
             stat_end = poll.utc_timestamp
         else:
-            start_start = None
+            stat_start = None
             stat_end = None
         res.update({
             'shortest successful': successful_extremes[0][1],

Modified: zc.async/trunk/src/zc/async/utils.py
===================================================================
--- zc.async/trunk/src/zc/async/utils.py	2010-09-01 13:52:38 UTC (rev 116090)
+++ zc.async/trunk/src/zc/async/utils.py	2010-09-01 14:07:46 UTC (rev 116091)
@@ -282,7 +282,7 @@
             if not trans_ct % 5:
                 log.warning(
                     '%d consecutive transaction errors while %s',
-                    ct, identifier, exc_info=True)
+                    trans_ct, identifier, exc_info=True)
                 res = None
         except EXPLOSIVE_ERRORS:
             tm.abort()



More information about the checkins mailing list