[Checkins] SVN: z3c.table/trunk/ Fixed SelectedItemColumn.update when just one item was selected

Adam Groszer agroszer at gmail.com
Wed Aug 3 06:59:28 EDT 2011


Log message for revision 122451:
  Fixed SelectedItemColumn.update when just one item was selected

Changed:
  U   z3c.table/trunk/CHANGES.txt
  U   z3c.table/trunk/src/z3c/table/column.py

-=-
Modified: z3c.table/trunk/CHANGES.txt
===================================================================
--- z3c.table/trunk/CHANGES.txt	2011-08-02 23:11:14 UTC (rev 122450)
+++ z3c.table/trunk/CHANGES.txt	2011-08-03 10:59:27 UTC (rev 122451)
@@ -5,7 +5,7 @@
 0.9.1 (unreleased)
 ------------------
 
-- Nothing changed yet.
+- Fixed SelectedItemColumn.update when just one item was selected
 
 
 0.9.0 (2010-08-09)

Modified: z3c.table/trunk/src/z3c/table/column.py
===================================================================
--- z3c.table/trunk/src/z3c/table/column.py	2011-08-02 23:11:14 UTC (rev 122450)
+++ z3c.table/trunk/src/z3c/table/column.py	2011-08-03 10:59:27 UTC (rev 122451)
@@ -373,6 +373,11 @@
             return self.defaultValue
         return super(EMailColumn, self).renderCell(item)
 
+def ensureList(item):
+    if not isinstance(item, (list, tuple)):
+        return [item]
+    return item
+
 class SelectedItemColumn(LinkColumn):
     """Link which can set an item."""
 
@@ -404,8 +409,8 @@
 
     def update(self):
         items = [item for item in self.table.values
-                 if self.getItemValue(item) in self.request.get(
-                     self.getItemKey(item), [])]
+                 if self.getItemValue(item) in ensureList(self.request.get(
+                     self.getItemKey(item), []))]
         if len(items):
             self.selectedItem = items.pop()
             self.table.selectedItems = [self.selectedItem]



More information about the checkins mailing list