[Checkins] SVN: grok/trunk/ fix tests now that error views no longer by default provide ISystemErrorView

Jan-Wijbrand Kolman janwijbrand at gmail.com
Tue Feb 8 05:58:24 EST 2011


Log message for revision 120199:
  fix tests now that error views no longer by default provide ISystemErrorView

Changed:
  U   grok/trunk/CHANGES.txt
  U   grok/trunk/src/grok/ftests/errorviews/errorviews.py

-=-
Modified: grok/trunk/CHANGES.txt
===================================================================
--- grok/trunk/CHANGES.txt	2011-02-08 10:47:12 UTC (rev 120198)
+++ grok/trunk/CHANGES.txt	2011-02-08 10:58:23 UTC (rev 120199)
@@ -4,13 +4,12 @@
 1.5 (unreleased)
 ================
 
-- Nothing changed yet.
+- Fix tests now that error views no longer by default provide ISystemErrorView.
 
-
 1.4.2 (2011-01-20)
 ==================
 
-- Should've listed IApplicatio as part of the grok API too.
+- Should've listed IApplication as part of the grok API too.
 
 1.4.1 (2011-01-20)
 ==================

Modified: grok/trunk/src/grok/ftests/errorviews/errorviews.py
===================================================================
--- grok/trunk/src/grok/ftests/errorviews/errorviews.py	2011-02-08 10:47:12 UTC (rev 120198)
+++ grok/trunk/src/grok/ftests/errorviews/errorviews.py	2011-02-08 10:58:23 UTC (rev 120199)
@@ -9,9 +9,13 @@
   >>> print view()
   A system error occurred.
 
-  >>> view.isSystemError()
-  True
+Error views no longer by default provide ISystemErrorView. It would result in
+duplicate log output otherwise.
 
+  >>> from zope.browser.interfaces import ISystemErrorView
+  >>> ISystemErrorView.providedBy(view)
+  False
+
   >>> from zope.publisher.interfaces import NotFound
   >>> request = TestRequest()
   >>> error = NotFound(object(), request)
@@ -40,9 +44,6 @@
   >>> print view()
   This is my idea of an exception view.
 
-  >>> view.isSystemError()
-  True
-
   >>> from grok import NotFoundView
   >>> class MyNotFoundView(NotFoundView):
   ...     def render(self):



More information about the checkins mailing list