[Checkins] SVN: Products.PluggableAuthService/trunk/ In the ZODBRoleManager made it clearer that adding a removing a role
Maurits van Rees
m.van.rees at zestsoftware.nl
Thu Feb 10 08:04:31 EST 2011
Log message for revision 120252:
In the ZODBRoleManager made it clearer that adding a removing a role
does not have much effect if you do not do the same in the root of
the site (at the bottom of the Security tab at manage_access).
Fixes https://bugs.launchpad.net/zope-pas/+bug/672694
Changed:
U Products.PluggableAuthService/trunk/CHANGES.txt
U Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/ZODBRoleManager.py
U Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/www/zrRoles.zpt
-=-
Modified: Products.PluggableAuthService/trunk/CHANGES.txt
===================================================================
--- Products.PluggableAuthService/trunk/CHANGES.txt 2011-02-10 07:44:24 UTC (rev 120251)
+++ Products.PluggableAuthService/trunk/CHANGES.txt 2011-02-10 13:04:29 UTC (rev 120252)
@@ -4,6 +4,11 @@
1.7.3 (unreleased)
------------------
+- In the ZODBRoleManager made it clearer that adding a removing a role
+ does not have much effect if you do not do the same in the root of
+ the site (at the bottom of the Security tab at manage_access).
+ Fixes https://bugs.launchpad.net/zope-pas/+bug/672694
+
- Return the created user in _doAddUser, to match change in
AccessControl 2.13.4.
Modified: Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/ZODBRoleManager.py
===================================================================
--- Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/ZODBRoleManager.py 2011-02-10 07:44:24 UTC (rev 120251)
+++ Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/ZODBRoleManager.py 2011-02-10 13:04:29 UTC (rev 120252)
@@ -225,6 +225,10 @@
""" Remove 'role_id' from the list of roles managed by this object.
o Raise KeyError if not found.
+
+ Note that if you really want to remove a role you should first
+ remove it from the roles in the root of the site (at the
+ bottom of the Security tab at manage_access).
"""
for principal_id in self._principal_roles.keys():
self.removeRoleFromPrincipal( role_id, principal_id )
@@ -402,7 +406,11 @@
, RESPONSE
, REQUEST=None
):
- """ Remove one or more roles via the ZMI.
+ """ Remove one or more role assignments via the ZMI.
+
+ Note that if you really want to remove a role you should first
+ remove it from the roles in the root of the site (at the
+ bottom of the Security tab at manage_access).
"""
role_ids = filter( None, role_ids )
@@ -414,7 +422,7 @@
for role_id in role_ids:
self.removeRole( role_id )
- message = 'Roles+removed'
+ message = 'Role+assignments+removed'
RESPONSE.redirect( '%s/manage_roles?manage_tabs_message=%s'
% ( self.absolute_url(), message )
Modified: Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/www/zrRoles.zpt
===================================================================
--- Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/www/zrRoles.zpt 2011-02-10 07:44:24 UTC (rev 120251)
+++ Products.PluggableAuthService/trunk/Products/PluggableAuthService/plugins/www/zrRoles.zpt 2011-02-10 13:04:29 UTC (rev 120252)
@@ -17,6 +17,11 @@
<h3> Current Roles <a href="?adding=1">(Add a role)</a></h3>
+<p>
+ Note that adding or removing a role here does not have much effect
+ if you do not do the same in the root of the site (at the bottom of
+ the Security tab at manage_access).
+</p>
<table width="100%" cellpadding="2" cellspacing="0">
<tr>
@@ -62,7 +67,7 @@
<td colspan="3">
<input type="hidden" name="role_ids:list:default" value="" />
<input type="submit" name="manage_removeRoles:method"
- value=" Remove Roles " />
+ value=" Remove Role Assignment " />
</td>
</tr>
More information about the checkins
mailing list