[Checkins] SVN: zopetoolkit/branches/1.0/z Bugfix updates

Gediminas Paulauskas menesis at pov.lt
Thu Jan 6 13:15:57 EST 2011


2011/1/5 Hanno Schlichting <hanno at hannosch.eu>:
> Hi.
>
> You updated a number of versions to new feature releases. That's not
> acceptable for the ZTK 1.0 series. At this point it will only see
> bug-fixes, as in third-dot releases. So zope.app.content 3.5.0 to
> 3.5.1 is fine, updating zope.app.broken from 3.5.0 to 3.6.0 is not.
> You can run "bin/checkversions -l 2 ztk-versions.cfg" to see which new
> versions qualify for inclusion (same for zopeapp-versions.cfg).
>
> If there's bug fixes in newer feature releases we'd like to have in
> ZTK 1.0, we'll have to backport those to appropriate branches and make
> releases of those.

Hello,

I expected such response and it is good that you noticed this change.

However, the changes I made were not accidental, but carefully
considered. Let me explain:

zope.app.broken
===============

3.6.0 (2010-09-25)
------------------

- Depend on new ``zope.processlifetime`` interfaces and implementations
  instead of using BBB imports from ``zope.app.appsetup``.

- Added test extra to declare test dependency on ``zope.testing``.

- Using Python's ``doctest`` module instead of depreacted
  ``zope.testing.doctest``.

This is a new "feature release" because it gets a new dependency on
zope.processlifetime. But in the context of ZTK 1.0, it was an
indirect dependency since zope.app.appsetup 3.11 (2009-05-13) when
zope.processlifetime was split from it. So this release drops one
dependency (in fact, more), and that's why I wanted it.

All the changes are exactly the same like was done to other modules
for ZTK 1.0. So I considered this zope.app.broken release to simply be
late into ZTK 1.0, but appriopriate nevertheless. I would like to keep
this change.

zope.copypastemove
==================

3.7.0 (2010-09-14)
------------------

- Honor the name given by the ``IObjectMover`` in
  ``OrderedContainerItemRenamer.renameItem``. It now returns the new of the
  obejct, too. Thanks to Marius Gedminas for the patch, and to Justin Ryan
  for the test.  Fixes
  https://bugs.launchpad.net/zope.copypastemove/+bug/98385.

- Add a check for name and container if the namechooser computes a
  name which is the same as the current name.
  Fixes https://bugs.launchpad.net/zope.copypastemove/+bug/123532

- Remove use of ``zope.testing.doctestunit`` in favor of stdlib's ``doctest``.

- Moved ``zope.copypastemove``-related tests from ``zope.container`` here.

The first two are bugfixes. Comments on
https://bugs.launchpad.net/zope.copypastemove/+bug/98385 raised
concerns about backwards compatibility, but then clarified that there
are none and the patch was accepted.

doctest change is the same like in other modules.

And the last one just add the test that was removed from
zope.container 3.10.1 (2009-12-29). Having functionality tested is
better than not, and this zope.copypastemove release has much more
tests. If they fail, means we had a problem with zope.copypastemove
3.6.0 as well, just did not know that.

So unless you consider the first bugfix to be an unacceptable
behaviour change, I would like to keep this upgrade.

zope.html
=========

2.2.0 (2010-11-19)
------------------

- Make the use of un-minified ckeditor source explicit

Giving a feature release number to such a minimal change looks like an
arbitrary choice by the developer. It is not important either, because
production sites do not run with devmode on.

But the buildbots choked on this one because of some bug in tarfile in
python2.4 that was triggered by this specific tarball, so I reverted
the zope.html version change.

> Could you please correct your checkin?

I have reverted the zope.html change, but would like to keep the other
two. Do you agree?

>
> Thanks,
> Hanno
>
> On Wed, Jan 5, 2011 at 5:59 PM, Gediminas Paulauskas <menesis at pov.lt> wrote:
>> Log message for revision 119393:
>>  Bugfix updates
>>
>>
>> Changed:
>>  U   zopetoolkit/branches/1.0/zopeapp-versions.cfg
>>  U   zopetoolkit/branches/1.0/ztk-versions.cfg
>>
>> -=-
>> Modified: zopetoolkit/branches/1.0/zopeapp-versions.cfg
>> ===================================================================
>> --- zopetoolkit/branches/1.0/zopeapp-versions.cfg       2011-01-05 16:56:32 UTC (rev 119392)
>> +++ zopetoolkit/branches/1.0/zopeapp-versions.cfg       2011-01-05 16:59:26 UTC (rev 119393)
>> @@ -4,15 +4,15 @@
>>  zope.app.appsetup = 3.14.0
>>  zope.app.authentication = 3.8.0
>>  zope.app.basicskin = 3.5.1
>> -zope.app.broken = 3.5.0
>> +zope.app.broken = 3.6.0
>>  zope.app.component = 3.9.2
>>  zope.app.container = 3.9.1
>> -zope.app.content = 3.5.0
>> +zope.app.content = 3.5.1
>>  zope.app.debug = 3.4.1
>>  zope.app.dependable = 3.5.1
>>  zope.app.error = 3.5.3
>>  zope.app.exception = 3.6.2
>> -zope.app.folder = 3.5.1
>> +zope.app.folder = 3.5.2
>>  zope.app.form = 4.0.2
>>  zope.app.generations = 3.6.0
>>  zope.app.http = 3.9.0
>> @@ -32,7 +32,7 @@
>>  zope.app.testing = 3.7.8
>>  zope.app.wsgi = 3.9.3
>>  zope.app.zcmlfiles = 3.7.0
>> -zope.app.zopeappgenerations = 3.5.0
>> +zope.app.zopeappgenerations = 3.5.1
>>  roman = 1.4.0
>>  wsgi-intercept = 0.4
>>  zc.sourcefactory = 0.7.0
>> @@ -64,7 +64,7 @@
>>  zope.app.undo = 3.5.0
>>  zope.app.zptpage = 3.5.1
>>  zope.file = 0.6.0
>> -zope.html = 2.1.0
>> +zope.html = 2.2.0
>>  zope.modulealias = 3.4.0
>>  zope.preference = 3.8.0
>>  zope.thread = 3.4
>>
>> Modified: zopetoolkit/branches/1.0/ztk-versions.cfg
>> ===================================================================
>> --- zopetoolkit/branches/1.0/ztk-versions.cfg   2011-01-05 16:56:32 UTC (rev 119392)
>> +++ zopetoolkit/branches/1.0/ztk-versions.cfg   2011-01-05 16:59:26 UTC (rev 119393)
>> @@ -17,7 +17,7 @@
>>  zope.contentprovider = 3.7.2
>>  zope.contenttype = 3.5.1
>>  zope.copy = 3.5.0
>> -zope.copypastemove = 3.6.0
>> +zope.copypastemove = 3.7.0
>>  zope.datetime = 3.4.0
>>  zope.deferredimport = 3.5.3
>>  zope.deprecation = 3.4.0
>> @@ -48,7 +48,7 @@
>>  zope.processlifetime = 1.0
>>  zope.proxy = 3.6.1
>>  zope.ptresource = 3.9.0
>> -zope.publisher = 3.12.4
>> +zope.publisher = 3.12.6
>>  zope.ramcache = 1.0
>>  zope.schema = 3.7.1
>>  zope.security = 3.7.4
>> @@ -59,7 +59,7 @@
>>  zope.session = 3.9.3
>>  zope.site = 3.9.2
>>  zope.size = 3.4.1
>> -zope.structuredtext = 3.5.0
>> +zope.structuredtext = 3.5.1
>>  zope.tal = 3.5.2
>>  zope.tales = 3.5.1
>>  zope.testing = 3.9.5
>> @@ -94,7 +94,7 @@
>>  ZConfig = 2.8.0
>>  zc.recipe.egg = 1.2.2
>>  zc.recipe.testrunner = 1.2.1
>> -zc.resourcelibrary = 1.3.1
>> +zc.resourcelibrary = 1.3.2
>>  zdaemon = 2.0.4
>>  ZODB3 = 3.9.7
>>  zope.mkzeoinstance = 3.9.4
>>
>> _______________________________________________
>> checkins mailing list
>> checkins at zope.org
>> https://mail.zope.org/mailman/listinfo/checkins
>>
>


More information about the checkins mailing list