[Checkins] SVN: megrok.strictrequire/trunk/ Don't check the requirement directive for ViewletManager, as these are not exposed as views. Some pep8.

Jan-Jaap Driessen jdriessen at thehealthagency.com
Mon Jul 11 15:33:38 EDT 2011


Log message for revision 122148:
   Don't check the requirement directive for ViewletManager, as these are not exposed as views. Some pep8.

Changed:
  U   megrok.strictrequire/trunk/CHANGES.txt
  U   megrok.strictrequire/trunk/src/megrok/strictrequire/meta.py
  U   megrok.strictrequire/trunk/src/megrok/strictrequire/tests/checkrequire.txt
  U   megrok.strictrequire/trunk/src/megrok/strictrequire/tests/fixtures.py

-=-
Modified: megrok.strictrequire/trunk/CHANGES.txt
===================================================================
--- megrok.strictrequire/trunk/CHANGES.txt	2011-07-11 18:27:56 UTC (rev 122147)
+++ megrok.strictrequire/trunk/CHANGES.txt	2011-07-11 19:33:38 UTC (rev 122148)
@@ -6,6 +6,8 @@
 
 - Use the groktoolkit versions.
 
+- Don't check the requirement directive for ViewletManager, as these are
+  not exposed as views.
 
 0.3 (2010-05-18)
 ----------------

Modified: megrok.strictrequire/trunk/src/megrok/strictrequire/meta.py
===================================================================
--- megrok.strictrequire/trunk/src/megrok/strictrequire/meta.py	2011-07-11 18:27:56 UTC (rev 122147)
+++ megrok.strictrequire/trunk/src/megrok/strictrequire/meta.py	2011-07-11 19:33:38 UTC (rev 122148)
@@ -14,6 +14,7 @@
 import martian
 import grok
 
+
 class SecurityError(grok.GrokError):
     pass
 
@@ -39,11 +40,6 @@
     martian.component(grok.Viewlet)
 
 
-class CheckRequireGrokkerViewletmanager(CheckRequireGrokker):
-    """Ensure every grok.ViewletManager has a grok.require directive"""
-    martian.component(grok.ViewletManager)
-
-
 class CheckRequireRESTGrokker(martian.MethodGrokker):
     """Ensure every grok.REST has a grok.require directive"""
     martian.component(grok.REST)

Modified: megrok.strictrequire/trunk/src/megrok/strictrequire/tests/checkrequire.txt
===================================================================
--- megrok.strictrequire/trunk/src/megrok/strictrequire/tests/checkrequire.txt	2011-07-11 18:27:56 UTC (rev 122147)
+++ megrok.strictrequire/trunk/src/megrok/strictrequire/tests/checkrequire.txt	2011-07-11 19:33:38 UTC (rev 122148)
@@ -11,7 +11,7 @@
 
     >>> from grok.testing import grok_component
     >>> from megrok.strictrequire.tests.fixtures import (
-    ...     NoRequireView, NoRequireViewletManager, NoRequireViewlet)
+    ...     NoRequireView, NoRequireViewlet)
     >>> grok_component('NoRequireView', NoRequireView)
     Traceback (most recent call last):
     ...
@@ -19,13 +19,6 @@
     <class 'megrok.strictrequire.tests.fixtures.NoRequireView'>
     to use the grok.require directive!
 
-    >>> grok_component('NoRequireViewletManager', NoRequireViewletManager)
-    Traceback (most recent call last):
-    ...
-    SecurityError: megrok.strictrequire requires
-    <class 'megrok.strictrequire.tests.fixtures.NoRequireViewletManager'>
-    to use the grok.require directive!
-
     >>> grok_component('NoRequireViewlet', NoRequireViewlet)
     Traceback (most recent call last):
     ...

Modified: megrok.strictrequire/trunk/src/megrok/strictrequire/tests/fixtures.py
===================================================================
--- megrok.strictrequire/trunk/src/megrok/strictrequire/tests/fixtures.py	2011-07-11 18:27:56 UTC (rev 122147)
+++ megrok.strictrequire/trunk/src/megrok/strictrequire/tests/fixtures.py	2011-07-11 19:33:38 UTC (rev 122148)
@@ -56,6 +56,7 @@
 
 class NoRequireJSON(grok.JSON):
     grok.context(zope.interface.Interface)
+
     def foobar(self):
         pass
 



More information about the checkins mailing list