[Checkins] SVN: ZConfig/branches/LP-481512-reopen-logs/ZConfig/components/logger/loghandler.py Fix thread safety for FileHandler.reopen.

Gary Poster gary.poster at canonical.com
Thu Jul 28 08:27:28 EDT 2011


Log message for revision 122393:
  Fix thread safety for FileHandler.reopen.

Changed:
  U   ZConfig/branches/LP-481512-reopen-logs/ZConfig/components/logger/loghandler.py

-=-
Modified: ZConfig/branches/LP-481512-reopen-logs/ZConfig/components/logger/loghandler.py
===================================================================
--- ZConfig/branches/LP-481512-reopen-logs/ZConfig/components/logger/loghandler.py	2011-07-28 12:27:25 UTC (rev 122392)
+++ ZConfig/branches/LP-481512-reopen-logs/ZConfig/components/logger/loghandler.py	2011-07-28 12:27:28 UTC (rev 122393)
@@ -84,8 +84,12 @@
         _remove_from_reopenable(self._wr)
 
     def reopen(self):
-        self.stream.close()
-        self.stream = open(self.baseFilename, self.mode)
+        self.acquire()
+        try:
+            self.stream.close()
+            self.stream = open(self.baseFilename, self.mode)
+        finally:
+            self.release()
 
 
 class Win32FileHandler(FileHandler):



More information about the checkins mailing list