[Checkins] SVN: relstorage/trunk/relstorage/adapters/packundo.py Alter comment; the policy is to lock when you write to the transaction table, regardless.

Martijn Pieters mj at zopatista.com
Tue Mar 1 05:54:42 EST 2011


Log message for revision 120639:
  Alter comment; the policy is to lock when you write to the transaction table, regardless.

Changed:
  U   relstorage/trunk/relstorage/adapters/packundo.py

-=-
Modified: relstorage/trunk/relstorage/adapters/packundo.py
===================================================================
--- relstorage/trunk/relstorage/adapters/packundo.py	2011-03-01 10:16:42 UTC (rev 120638)
+++ relstorage/trunk/relstorage/adapters/packundo.py	2011-03-01 10:54:42 UTC (rev 120639)
@@ -769,9 +769,7 @@
         stmt = self._script_pack_object_ref
         self.runner.run_script(cursor, stmt)
 
-        # Do we need to hold the commit lock for this section? RelStorage
-        # normally ignores transactions where packed = TRUE. We hold the
-        # commit lock during packing to set the packed flag already.
+        # We need a commit lock when touching the transaction table though.
         self.locker.hold_commit_lock(cursor)
         log.debug("pack: removing empty packed transactions")
         stmt = """



More information about the checkins mailing list