[Checkins] SVN: zope.schema/branches/jinty-python3/src/zope/schema/_schema.py simplify getFieldsInOrder

Brian Sutherland jinty at web.de
Fri Oct 14 05:44:40 EST 2011


Log message for revision 123092:
  simplify getFieldsInOrder

Changed:
  U   zope.schema/branches/jinty-python3/src/zope/schema/_schema.py

-=-
Modified: zope.schema/branches/jinty-python3/src/zope/schema/_schema.py
===================================================================
--- zope.schema/branches/jinty-python3/src/zope/schema/_schema.py	2011-10-14 10:27:58 UTC (rev 123091)
+++ zope.schema/branches/jinty-python3/src/zope/schema/_schema.py	2011-10-14 10:44:40 UTC (rev 123092)
@@ -35,18 +35,11 @@
             fields[name] = attr
     return fields
 
-_field_key = lambda x: x[1].order
-
 def getFieldsInOrder(schema,
-                     _fieldsorter=None):
+                     _field_key=lambda x: x[1].order):
     """Return a list of (name, value) tuples in native schema order.
     """
-    fields = list(getFields(schema).items())
-    if _fieldsorter is not None:
-        fields.sort(_fieldsorter)
-    else:
-        fields.sort(key=_field_key)
-    return fields
+    return sorted(getFields(schema).items(), key=_field_key)
 
 
 def getFieldNamesInOrder(schema):



More information about the checkins mailing list