[Checkins] SVN: Products.GenericSetup/trunk/ explicit is better than implicit

Yvo Schubbe y.2011 at wcm-solutions.de
Fri Oct 28 08:22:36 UTC 2011


Log message for revision 123171:
  explicit is better than implicit

Changed:
  U   Products.GenericSetup/trunk/Products/GenericSetup/context.py
  U   Products.GenericSetup/trunk/docs/CHANGES.rst

-=-
Modified: Products.GenericSetup/trunk/Products/GenericSetup/context.py
===================================================================
--- Products.GenericSetup/trunk/Products/GenericSetup/context.py	2011-10-28 02:32:13 UTC (rev 123170)
+++ Products.GenericSetup/trunk/Products/GenericSetup/context.py	2011-10-28 08:22:35 UTC (rev 123171)
@@ -121,7 +121,9 @@
         """
         return self._should_purge
 
+InitializeClass(SetupEnviron)
 
+
 class BaseContext(SetupEnviron):
 
     security = ClassSecurityInfo()
@@ -176,7 +178,9 @@
         """
         self._messages[:] = []
 
+InitializeClass(BaseContext)
 
+
 class DirectoryImportContext( BaseContext ):
 
     implements(IChunkableImportContext)
@@ -269,7 +273,7 @@
 
         return names
 
-InitializeClass( DirectoryImportContext )
+InitializeClass(DirectoryImportContext)
 
 
 class DirectoryExportContext( BaseContext ):
@@ -311,7 +315,7 @@
         file.write( text )
         file.close()
 
-InitializeClass( DirectoryExportContext )
+InitializeClass(DirectoryExportContext)
 
 
 class TarballImportContext( BaseContext ):
@@ -409,7 +413,9 @@
         except KeyError:
             return None
 
+InitializeClass(TarballImportContext)
 
+
 class TarballExportContext( BaseContext ):
 
     implements(IExportContext)
@@ -477,7 +483,7 @@
         """
         return self._archive_filename
 
-InitializeClass( TarballExportContext )
+InitializeClass(TarballExportContext)
 
 
 class SnapshotExportContext( BaseContext ):
@@ -582,7 +588,7 @@
 
         return current
 
-InitializeClass( SnapshotExportContext )
+InitializeClass(SnapshotExportContext)
 
 
 class SnapshotImportContext( BaseContext ):
@@ -708,4 +714,4 @@
 
         return self._tool.restrictedTraverse( path )
 
-InitializeClass( SnapshotImportContext )
+InitializeClass(SnapshotImportContext)

Modified: Products.GenericSetup/trunk/docs/CHANGES.rst
===================================================================
--- Products.GenericSetup/trunk/docs/CHANGES.rst	2011-10-28 02:32:13 UTC (rev 123170)
+++ Products.GenericSetup/trunk/docs/CHANGES.rst	2011-10-28 08:22:35 UTC (rev 123171)
@@ -4,6 +4,8 @@
 1.6.4 (unreleased)
 ------------------
 
+- Added three missing explicit InitializeClass calls.
+
 - Adjust test assertions in `test_differ` to cope with changes to the diff
   library done in Python 2.7.
 



More information about the checkins mailing list