[Checkins] SVN: Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py optimize catalog.addColumn by avoiding intermediate list creation

Hano Schlichting cvs-admin at zope.org
Sat Apr 7 11:42:53 UTC 2012


Log message for revision 125059:
  optimize catalog.addColumn by avoiding intermediate list creation
  

Changed:
  U   Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py

-=-
Modified: Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py
===================================================================
--- Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py	2012-04-07 11:08:35 UTC (rev 125058)
+++ Products.ZCatalog/trunk/src/Products/ZCatalog/Catalog.py	2012-04-07 11:42:49 UTC (rev 125059)
@@ -176,10 +176,8 @@
         if default_value in (None, ''):
             default_value = MV
 
-        for key, value in self.data.items():
-            rec = list(value)
-            rec.append(default_value)
-            self.data[key] = tuple(rec)
+        for key, value in self.data.iteritems():
+            self.data[key] = value + (default_value, )
 
         self.names = tuple(names)
         self.schema = schema



More information about the checkins mailing list