[Checkins] SVN: z3c.form/trunk/ Remove ":list" from radio inputs, since radio buttons can be only one

Stephan Richter srichter at gmail.com
Wed Jan 4 11:34:31 UTC 2012


Log message for revision 123935:
  Remove ":list" from radio inputs, since radio buttons can be only one 
  value by definition. See LP580840.
  
  

Changed:
  U   z3c.form/trunk/CHANGES.txt
  U   z3c.form/trunk/src/z3c/form/browser/README.txt
  U   z3c.form/trunk/src/z3c/form/browser/radio.py
  U   z3c.form/trunk/src/z3c/form/browser/radio.txt
  U   z3c.form/trunk/src/z3c/form/hint.txt

-=-
Modified: z3c.form/trunk/CHANGES.txt
===================================================================
--- z3c.form/trunk/CHANGES.txt	2012-01-04 11:24:52 UTC (rev 123934)
+++ z3c.form/trunk/CHANGES.txt	2012-01-04 11:34:31 UTC (rev 123935)
@@ -2,9 +2,12 @@
 CHANGES
 =======
 
-2.5.2 (unreleased)
+2.6.0 (unreleased)
 ------------------
 
+- Remove ":list" from radio inputs, since radio buttons can be only one value
+  by definition. See LP580840.
+
 - Remove dependency on zope.site.hooks, which was moved to zope.component in
   3.8.0 (present in ZTK 1.0 and above).
 

Modified: z3c.form/trunk/src/z3c/form/browser/README.txt
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/README.txt	2012-01-04 11:24:52 UTC (rev 123934)
+++ z3c.form/trunk/src/z3c/form/browser/README.txt	2012-01-04 11:34:31 UTC (rev 123935)
@@ -103,14 +103,14 @@
   >>> print widget.render()
   <span class="option">
     <label for="foo-0">
-      <input type="radio" id="foo-0" name="bar:list"
+      <input type="radio" id="foo-0" name="bar"
              class="radio-widget required bool-field" value="true"
              checked="checked" />
       <span class="label">yes</span>
     </label>
   </span><span class="option">
     <label for="foo-1">
-      <input type="radio" id="foo-1" name="bar:list"
+      <input type="radio" id="foo-1" name="bar"
              class="radio-widget required bool-field" value="false" />
       <span class="label">no</span>
     </label>

Modified: z3c.form/trunk/src/z3c/form/browser/radio.py
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/radio.py	2012-01-04 11:24:52 UTC (rev 123934)
+++ z3c.form/trunk/src/z3c/form/browser/radio.py	2012-01-04 11:34:31 UTC (rev 123935)
@@ -51,7 +51,7 @@
                 label = translate(term.title, context=self.request,
                                   default=term.title)
             self.items.append(
-                {'id':id, 'name':self.name + ':list', 'value':term.token,
+                {'id':id, 'name':self.name, 'value':term.token,
                  'label':label, 'checked':checked})
 
 

Modified: z3c.form/trunk/src/z3c/form/browser/radio.txt
===================================================================
--- z3c.form/trunk/src/z3c/form/browser/radio.txt	2012-01-04 11:24:52 UTC (rev 123934)
+++ z3c.form/trunk/src/z3c/form/browser/radio.txt	2012-01-04 11:34:31 UTC (rev 123935)
@@ -72,13 +72,13 @@
   >>> print widget.render()
   <span class="option">
     <label for="widget-id-0">
-      <input type="radio" id="widget-id-0" name="widget.name:list"
+      <input type="radio" id="widget-id-0" name="widget.name"
              class="radio-widget" value="true" />
       <span class="label">yes</span>
     </label>
   </span><span class="option">
     <label for="widget-id-1">
-      <input type="radio" id="widget-id-1" name="widget.name:list"
+      <input type="radio" id="widget-id-1" name="widget.name"
              class="radio-widget" value="false" />
       <span class="label">no</span>
     </label>
@@ -93,13 +93,13 @@
   >>> print widget.render()
   <span class="option">
     <label for="widget-id-0">
-      <input type="radio" id="widget-id-0" name="widget.name:list"
+      <input type="radio" id="widget-id-0" name="widget.name"
              class="radio-widget" value="true" checked="checked" />
       <span class="label">yes</span>
     </label>
   </span><span class="option">
     <label for="widget-id-1">
-      <input type="radio" id="widget-id-1" name="widget.name:list"
+      <input type="radio" id="widget-id-1" name="widget.name"
              class="radio-widget" value="false" />
       <span class="label">no</span>
     </label>
@@ -118,5 +118,6 @@
   >>> widget.value = ['true']
   >>> widget.mode = interfaces.HIDDEN_MODE
   >>> print widget.render()
-  <input id="widget-id-0" name="widget.name:list" value="true" class="hidden-widget" type="hidden" />
-  
\ No newline at end of file
+  <input id="widget-id-0" name="widget.name" value="true"
+         class="hidden-widget" type="hidden" />
+

Modified: z3c.form/trunk/src/z3c/form/hint.txt
===================================================================
--- z3c.form/trunk/src/z3c/form/hint.txt	2012-01-04 11:24:52 UTC (rev 123934)
+++ z3c.form/trunk/src/z3c/form/hint.txt	2012-01-04 11:34:31 UTC (rev 123935)
@@ -313,7 +313,7 @@
   <span class="option">
     <label for="form-widgets-boolField-0">
       <input id="form-widgets-boolField-0"
-             name="form.widgets.boolField:list"
+             name="form.widgets.boolField"
              class="radio-widget required bool-field"
              title="This is a Bool field." value="true"
              checked="checked" type="radio" />
@@ -323,7 +323,7 @@
   <span class="option">
     <label for="form-widgets-boolField-1">
       <input id="form-widgets-boolField-1"
-             name="form.widgets.boolField:list"
+             name="form.widgets.boolField"
              class="radio-widget required bool-field"
              title="This is a Bool field." value="false"
              type="radio" />
@@ -337,7 +337,7 @@
   <span class="option">
     <label for="form-widgets-checkboxBoolField-0">
       <input id="form-widgets-checkboxBoolField-0"
-             name="form.widgets.checkboxBoolField:list"
+             name="form.widgets.checkboxBoolField"
              class="radio-widget required bool-field"
              title="This is a Bool field displayed suing a checkbox."
              value="true" checked="checked" type="radio" />
@@ -347,7 +347,7 @@
   <span class="option">
     <label for="form-widgets-checkboxBoolField-1">
       <input id="form-widgets-checkboxBoolField-1"
-             name="form.widgets.checkboxBoolField:list"
+             name="form.widgets.checkboxBoolField"
              class="radio-widget required bool-field"
              title="This is a Bool field displayed suing a checkbox."
              value="false" type="radio" />
@@ -481,7 +481,7 @@
   <span class="option">
     <label for="form-widgets-listField-0">
       <input id="form-widgets-listField-0"
-             name="form.widgets.listField:list"
+             name="form.widgets.listField"
              class="radio-widget required list-field"
              title="This is a List field." value="1"
              checked="checked" type="radio" />
@@ -491,7 +491,7 @@
   <span class="option">
     <label for="form-widgets-listField-1">
       <input id="form-widgets-listField-1"
-             name="form.widgets.listField:list"
+             name="form.widgets.listField"
              class="radio-widget required list-field"
              title="This is a List field." value="2"
              type="radio" />
@@ -501,7 +501,7 @@
   <span class="option">
     <label for="form-widgets-listField-2">
       <input id="form-widgets-listField-2"
-             name="form.widgets.listField:list"
+             name="form.widgets.listField"
              class="radio-widget required list-field"
              title="This is a List field." value="3"
              checked="checked" type="radio" />
@@ -511,7 +511,7 @@
   <span class="option">
     <label for="form-widgets-listField-3">
       <input id="form-widgets-listField-3"
-             name="form.widgets.listField:list"
+             name="form.widgets.listField"
              class="radio-widget required list-field"
              title="This is a List field." value="4"
              type="radio" />
@@ -521,7 +521,7 @@
   <span class="option">
     <label for="form-widgets-listField-4">
       <input id="form-widgets-listField-4"
-             name="form.widgets.listField:list"
+             name="form.widgets.listField"
              class="radio-widget required list-field"
              title="This is a List field." value="5"
              type="radio" />
@@ -593,7 +593,7 @@
   <span class="option">
     <label for="form-widgets-tupleField-0">
       <input id="form-widgets-tupleField-0"
-             name="form.widgets.tupleField:list"
+             name="form.widgets.tupleField"
              class="radio-widget required tuple-field"
              title="This is a Tuple field." value="1"
              checked="checked" type="radio" />
@@ -603,7 +603,7 @@
   <span class="option">
     <label for="form-widgets-tupleField-1">
       <input id="form-widgets-tupleField-1"
-             name="form.widgets.tupleField:list"
+             name="form.widgets.tupleField"
              class="radio-widget required tuple-field"
              title="This is a Tuple field." value="2"
              type="radio" />
@@ -613,7 +613,7 @@
   <span class="option">
     <label for="form-widgets-tupleField-2">
       <input id="form-widgets-tupleField-2"
-             name="form.widgets.tupleField:list"
+             name="form.widgets.tupleField"
              class="radio-widget required tuple-field"
              title="This is a Tuple field." value="3"
              checked="checked" type="radio" />
@@ -623,7 +623,7 @@
   <span class="option">
     <label for="form-widgets-tupleField-3">
       <input id="form-widgets-tupleField-3"
-             name="form.widgets.tupleField:list"
+             name="form.widgets.tupleField"
              class="radio-widget required tuple-field"
              title="This is a Tuple field." value="4"
              type="radio" />
@@ -633,7 +633,7 @@
   <span class="option">
     <label for="form-widgets-tupleField-4">
       <input id="form-widgets-tupleField-4"
-             name="form.widgets.tupleField:list"
+             name="form.widgets.tupleField"
              class="radio-widget required tuple-field"
              title="This is a Tuple field." value="5"
              type="radio" />



More information about the checkins mailing list