[Checkins] SVN: zope.schema/trunk/ Don't assert equality to True.
Tres Seaver
cvs-admin at zope.org
Wed Nov 21 19:45:21 UTC 2012
Log message for revision 128408:
Don't assert equality to True.
Changed:
_U zope.schema/trunk/
U zope.schema/trunk/src/zope/schema/tests/test__field.py
-=-
Modified: zope.schema/trunk/src/zope/schema/tests/test__field.py
===================================================================
--- zope.schema/trunk/src/zope/schema/tests/test__field.py 2012-11-21 19:24:00 UTC (rev 128407)
+++ zope.schema/trunk/src/zope/schema/tests/test__field.py 2012-11-21 19:45:20 UTC (rev 128408)
@@ -1512,15 +1512,15 @@
errors = self._getErrors(objf.validate, Broken())
self.assertEqual(len(errors), 2)
err = errors[0]
- self.assertEqual(isinstance(err, SchemaNotFullyImplemented), True)
+ self.assertTrue(isinstance(err, SchemaNotFullyImplemented))
nested = err.args[0]
- self.assertEqual(isinstance(nested, AttributeError), True)
- self.assertEqual("'foo'" in str(nested), True)
+ self.assertTrue(isinstance(nested, AttributeError))
+ self.assertTrue("'foo'" in str(nested))
err = errors[1]
- self.assertEqual(isinstance(err, SchemaNotFullyImplemented), True)
+ self.assertTrue(isinstance(err, SchemaNotFullyImplemented))
nested = err.args[0]
- self.assertEqual(isinstance(nested, AttributeError), True)
- self.assertEqual("'bar'" in str(nested), True)
+ self.assertTrue(isinstance(nested, AttributeError))
+ self.assertTrue("'bar'" in str(nested))
def test__validate_w_value_providing_schema_but_invalid_fields(self):
from zope.interface import implementer
@@ -1539,10 +1539,10 @@
errors = self._getErrors(objf.validate, Broken())
self.assertEqual(len(errors), 2)
err = errors[0]
- self.assertEqual(isinstance(err, RequiredMissing), True)
+ self.assertTrue(isinstance(err, RequiredMissing))
self.assertEqual(err.args, ('foo',))
err = errors[1]
- self.assertEqual(isinstance(err, WrongType), True)
+ self.assertTrue(isinstance(err, WrongType))
self.assertEqual(err.args, (1, text_type, 'bar'))
def test__validate_w_value_providing_schema(self):
More information about the checkins
mailing list