[Checkins] SVN: zope.i18n/branches/lazy-tds/ The ZCML directive handler for a translation domain registration now

[Malthe Borch]

I just noticed that Hanno had actual feedback / review on various code
snippets. Commenting below:

On 10 October 2012 12:47, Hanno Schlichting <hanno at hannosch.eu> wrote:
> Why did you remove those tests? They look like they are testing
> internals, but was that the only reason?

It's testing internals, and the internals changed: we now don't load
(or compile) catalogs before they're actually being used. I could of
course keep the tests, but simply shift them down below the
translate-calls.

> You are setting self.languages to an empty set in the init. Why use a
> tuple here?

Because ``SimpleTranslationDomain`` declares it as a descriptor (in
order to provide a set computed from the messages contained).

> The compile_mo_file should be conditional on the
> config.COMPILE_MO_FILES flag. The automatic mo file compilation is an
> optional feature and not everyone wants it. Especially in environments
> where the application process doesn't have write permissions to the
> file system.

Okay, I see. I must have mistakenly dropped a condition.

\malthe