[Checkins] SVN: Products.GenericSetup/trunk/ Use clickable labels with checkboxes on import, export and upgrade forms

Thomas Desvenain cvs-admin at zope.org
Mon Oct 15 21:49:02 UTC 2012


Log message for revision 128018:
  Use clickable labels with checkboxes on import, export and upgrade forms
  to improve usability.

Changed:
  U   Products.GenericSetup/trunk/Products/GenericSetup/www/sutExportSteps.zpt
  U   Products.GenericSetup/trunk/Products/GenericSetup/www/sutImportSteps.zpt
  U   Products.GenericSetup/trunk/Products/GenericSetup/www/upgradeStep.zpt
  U   Products.GenericSetup/trunk/docs/CHANGES.rst

-=-
Modified: Products.GenericSetup/trunk/Products/GenericSetup/www/sutExportSteps.zpt
===================================================================
--- Products.GenericSetup/trunk/Products/GenericSetup/www/sutExportSteps.zpt	2012-10-15 21:47:23 UTC (rev 128017)
+++ Products.GenericSetup/trunk/Products/GenericSetup/www/sutExportSteps.zpt	2012-10-15 21:48:59 UTC (rev 128018)
@@ -33,12 +33,15 @@
                      repeat[ 'step_id' ].odd and 'row-normal' or 'row-hilite'" >
    <td class="list-item" width="16">
     <input type="checkbox" name="ids:list" value="STEP_ID"
-           tal:attributes="value step_id" />
+           id="STEP_ID"
+           tal:attributes="id step_id;
+                           value step_id" />
    </td>
    <td align="right" class="list-item"
        tal:content="repeat/step_id/number">1</td>
    <td class="list-item">
-    <span tal:content="info/title">STEP TITLE</span><br />
+    <label tal:attributes="for step_id"
+           tal:content="info/title">STEP TITLE</label><br />
     <em tal:content="info/description">STEP DESCRIPTION</em>
    </td>
    <td class="list-item"

Modified: Products.GenericSetup/trunk/Products/GenericSetup/www/sutImportSteps.zpt
===================================================================
--- Products.GenericSetup/trunk/Products/GenericSetup/www/sutImportSteps.zpt	2012-10-15 21:47:23 UTC (rev 128017)
+++ Products.GenericSetup/trunk/Products/GenericSetup/www/sutImportSteps.zpt	2012-10-15 21:48:59 UTC (rev 128018)
@@ -68,12 +68,14 @@
                      style python:info['invalid'] and 'background: red' or None" >
    <td class="list-item" width="16">
     <input type="checkbox" name="ids:list" value="STEP_ID"
-           tal:attributes="value step_id" />
+           tal:attributes="id step_id;
+                           value step_id" />
    </td>
    <td align="right" class="list-item"
        tal:content="repeat/step_id/number">1</td>
    <td class="list-item">
-    <span tal:content="info/title">STEP TITLE</span><br />
+    <label tal:content="info/title"
+           tal:attributes="for step_id">STEP TITLE</label><br />
     <em tal:content="info/description">STEP DESCRIPTION</em>
    </td>
    <td class="list-item"

Modified: Products.GenericSetup/trunk/Products/GenericSetup/www/upgradeStep.zpt
===================================================================
--- Products.GenericSetup/trunk/Products/GenericSetup/www/upgradeStep.zpt	2012-10-15 21:47:23 UTC (rev 128017)
+++ Products.GenericSetup/trunk/Products/GenericSetup/www/upgradeStep.zpt	2012-10-15 21:48:59 UTC (rev 128018)
@@ -4,20 +4,26 @@
     <td>
       <input type="checkbox" name="upgrades:list"
              value="VALUE" checked="CHECKED"
-             tal:attributes="value info/id;
+
+             tal:attributes="id info/id;
+                             value info/id;
                              checked python:info['proposed'] and not show_old;
                              "/>
     </td>
     <td>
-      <div tal:replace="info/title">INFO</div><br/>
-      <div tal:replace="info/description">DESCRIPTION</div>
+      <label tal:attributes="for info/id"
+             tal:content="info/title">INFO</label><br/>
+      <label tal:attributes="for info/id"
+             tal:content="info/description">DESCRIPTION</label>
     </td>
     <td class="form-help">
-      <div tal:content="structure string:(${info/ssource} &amp;#8594; ${info/sdest})">PATH</div>
+      <label tal:attributes="for info/id"
+             tal:content="structure string:(${info/ssource} &amp;#8594; ${info/sdest})">PATH</label>
     </td>
     <td class="form-help">
-      <div tal:condition="info/done"
-           tal:replace="default">(done)</div>
+      <label tal:attributes="for info/id"
+             tal:condition="info/done"
+             tal:content="default">(done)</label>
     </td>
   </metal:upgrade-step>
 

Modified: Products.GenericSetup/trunk/docs/CHANGES.rst
===================================================================
--- Products.GenericSetup/trunk/docs/CHANGES.rst	2012-10-15 21:47:23 UTC (rev 128017)
+++ Products.GenericSetup/trunk/docs/CHANGES.rst	2012-10-15 21:48:59 UTC (rev 128018)
@@ -4,6 +4,9 @@
 1.7.3 (unreleased)
 ------------------
 
+- Use clickable labels with checkboxes on import, export and upgrade forms
+  to improve usability.
+
 - TBD
 
 



More information about the checkins mailing list