[Checkins] SVN: Products.CMFDefault/trunk/Products/CMFDefault/browser/content/rss.py Use a generator rather than a temporary list.

Charlie Clark cvs-admin at zope.org
Tue Sep 4 17:39:44 UTC 2012


Log message for revision 127691:
  Use a generator rather than a temporary list.

Changed:
  U   Products.CMFDefault/trunk/Products/CMFDefault/browser/content/rss.py

-=-
Modified: Products.CMFDefault/trunk/Products/CMFDefault/browser/content/rss.py
===================================================================
--- Products.CMFDefault/trunk/Products/CMFDefault/browser/content/rss.py	2012-09-04 15:35:53 UTC (rev 127690)
+++ Products.CMFDefault/trunk/Products/CMFDefault/browser/content/rss.py	2012-09-04 17:39:40 UTC (rev 127691)
@@ -46,14 +46,17 @@
         items = syndtool.getSyndicatableContent(self.context)
         items = sort(items, ((key, 'cmp', reverse and 'desc' or 'asc'),))
         items = LazyFilter(items, skip='View')
-        items = ({'title': o.Title(), 'description': o.Description(),
-                  'creators': o.listCreators(), 'subjects': o.Subject(),
-                  'rights': o.Rights(), 'publisher': o.Publisher(),
-                  'url': o.absolute_url(), 'date': o.modified().rfc822(),
-                  'uid': None}
-                  for idx, o in enumerate(items)
-                    if idx < self.synd_info.max_items)
-        return items
+        for idx, o in enumerate(items):
+            if idx < self.synd_info.max_items:
+                yield {'title': o.Title(),
+                       'description': o.Description(),
+                       'creators': o.listCreators(),
+                       'subjects': o.Subject(),
+                       'rights': o.Rights(),
+                       'publisher': o.Publisher(),
+                       'url': o.absolute_url(),
+                       'date': o.modified().rfc822(),
+                       'uid': None}
 
     @memoize
     @decode



More information about the checkins mailing list