[Checkins] [zopefoundation/ZODB] e7d8ca: Checkpoint of Python 3 port. Over 800 of the 897 u...

[Marius Gedminas]

On Wed, Feb 13, 2013 at 08:47:05PM -0800, GitHub wrote:
>   Branch: refs/heads/py3
>   Home:   https://github.com/zopefoundation/ZODB
>   Commit: e7d8ca7229998146f79e1f90302ae6486bc95a60
>       https://github.com/zopefoundation/ZODB/commit/e7d8ca7229998146f79e1f90302ae6486bc95a60
>   Author: Stephan Richter <srichter at cipherhealth.com>
>   Date:   2013-02-13 (Wed, 13 Feb 2013)

I reviewed this on Github.  I think I found one error:
https://github.com/zopefoundation/ZODB/commit/e7d8ca7229998146f79e1f90302ae6486bc95a60#L4R274

In src/ZODB/ConflictResolution.py near line 274 there's an if with both
branches containing the same code.

Everything else was basically nitpicking.

Curious: was anyone notified by email about the comments I added to the
commit?

Marius Gedminas
-- 
Parsing is considered a solved problem. Unfortunately, this view is naive,
rooted in the widely believed myth that programming languages exist.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://mail.zope.org/pipermail/checkins/attachments/20130214/8bb7b8b9/attachment.sig>