[Checkins] SVN: ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py Avoid ResourceWarnings in test suite.
Marius Gedminas
cvs-admin at zope.org
Thu Feb 14 10:56:17 UTC 2013
Log message for revision 129383:
Avoid ResourceWarnings in test suite.
Changed:
U ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py
-=-
Modified: ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py
===================================================================
--- ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py 2013-02-14 10:51:59 UTC (rev 129382)
+++ ZConfig/trunk/ZConfig/components/logger/tests/test_logger.py 2013-02-14 10:56:16 UTC (rev 129383)
@@ -45,6 +45,11 @@
return sio.getvalue() + "... Don't panic!"
+def read_file(filename):
+ with open(filename) as f:
+ return f.read()
+
+
class LoggingTestHelper:
# Not derived from unittest.TestCase; some test runners seem to
@@ -494,9 +499,9 @@
h.close()
# Check that the messages are in the right files::
- text1 = open(nfn1).read()
- text2 = open(nfn2).read()
- text3 = open(fn).read()
+ text1 = read_file(nfn1)
+ text2 = read_file(nfn2)
+ text3 = read_file(fn)
self.assert_("message 1" in text1)
self.assert_("message 2" in text1)
self.assert_("message 3" in text2)
More information about the checkins
mailing list