[Checkins] [zopefoundation/Acquisition] 3ce7f6: Merge r71220 from old branch:

GitHub noreply at github.com
Mon Feb 25 15:10:51 UTC 2013


  Branch: refs/heads/zope2-philikon-aq
  Home:   https://github.com/zopefoundation/Acquisition
  Commit: 3ce7f69c89940077d27ffbda2e8473fa24efc9f4
      https://github.com/zopefoundation/Acquisition/commit/3ce7f69c89940077d27ffbda2e8473fa24efc9f4
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-10 (Tue, 10 Jul 2007)

  Changed paths:
    A _Acquisition.c
    A tests.py

  Log Message:
  -----------
  Merge r71220 from old branch:
  Warming up: Make acquisition wrappers have __parent__ in addition to aq_parent
  (they point to the same thing).


  Commit: 062b381df20c0390c0f7cdb35e135ad3bb155bd8
      https://github.com/zopefoundation/Acquisition/commit/062b381df20c0390c0f7cdb35e135ad3bb155bd8
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-10 (Tue, 10 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Merge r71222 from old branch:
  Allow assignment to a wrapper's __parent__.


  Commit: 23e8cd65d54b0f5c79afa2c2402425ce33a663c1
      https://github.com/zopefoundation/Acquisition/commit/23e8cd65d54b0f5c79afa2c2402425ce33a663c1
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-24 (Tue, 24 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Merged from old philikon-aq-and-__parent__ branch:

Log message for revision 71221:
  Step 2: Make aq_acquire aware of __parent__ pointers, even if the object
  isn't acquisition wrapped.

Log message for revision 71223:
  Add another test that tests acquisition wrappers with containers that have __parent__.

Log message for revision 71225:
  Cosmetics: adjust a piece of code that I added earlier to the indentation
  style of the overall file

Log message for revision 71226:
  Cleanup:
  * no need to introduce another variable where we check for a __parent__ attribute
  * clean up after failed getattr (it throws an AttributeError)
  * properly DECREF the __parent__ attribute when it's no longer needed and
    the wrapper that is temporarily created from the __parent__ attribute.

Log message for revision 75578:
  Added a test to Acquisition that shows the current segmentation fault problem, when Acquisition goes in circles.

Log message for revision 76140:
  First attempt to fix 'Acquisition problem' when encountering cyclic hierarchies via __parent__ pointers. [hannosch, nouri]


In addition, Hanno and Nouri's fix was expanded to not only cover circular __parent__
pointers but also to cover a mixture of circular __parent__ and aq_parent pointers
(which can occur when old Implicit acquisition meets new __parent__ pointer code).

Also cleaned up much of the comments and added more comments.


  Commit: 755cb1208cc192f31a82d4897b48eeeb3f0a27eb
      https://github.com/zopefoundation/Acquisition/commit/755cb1208cc192f31a82d4897b48eeeb3f0a27eb
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-24 (Tue, 24 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Merged from old philikon-aq-and-__parent__ branch:

Log message for revision 71224:
  Step 3: Make aq_parent aware of __parent__ pointers.


  Commit: b74b92b4f2fb3145f2ee30549d583f49d2a651e0
      https://github.com/zopefoundation/Acquisition/commit/b74b92b4f2fb3145f2ee30549d583f49d2a651e0
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-24 (Tue, 24 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Merged from old philikon-aq-and-__parent__ branch:

Log message for revision 71227:
  Step 4: Make aq_get aware of __parent__ pointers.
  (Also some comment cosmetics in _Acquisition.c)

Log message for revision 71228:
  Test aq_parent property as well (in addition to aq_parent function)

Log message for revision 71229:
  Step 5: Make aq_chain aware of __parent__ pointers.


  Commit: da7cab2209fb49f3d94db8b693eb308def9c7569
      https://github.com/zopefoundation/Acquisition/commit/da7cab2209fb49f3d94db8b693eb308def9c7569
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-27 (Fri, 27 Jul 2007)

  Changed paths:
    M tests.py

  Log Message:
  -----------
  cosmetics (make it easier to read)


  Commit: add9eb0d403aa9e708e9bf949571c21dca8b6d40
      https://github.com/zopefoundation/Acquisition/commit/add9eb0d403aa9e708e9bf949571c21dca8b6d40
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-27 (Fri, 27 Jul 2007)

  Changed paths:
    M _Acquisition.c

  Log Message:
  -----------
  Factor actual implementation of Wrapper_inContextOf out to a reusable
function so that we can write a module-level function for that functionality
as well.


  Commit: 1b5d5aa8588c0ac80916e7fabb6b8e836421218e
      https://github.com/zopefoundation/Acquisition/commit/1b5d5aa8588c0ac80916e7fabb6b8e836421218e
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-27 (Fri, 27 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Add a module-level aq_inContextOf function, along the lines of the
module-level aq_acquire, aq_inner, aq_parent, etc. functions.


  Commit: af010456afa7024ebc8b28dd31e393aeedf820c7
      https://github.com/zopefoundation/Acquisition/commit/af010456afa7024ebc8b28dd31e393aeedf820c7
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-27 (Fri, 27 Jul 2007)

  Changed paths:
    M tests.py

  Log Message:
  -----------
  better test name ;)


  Commit: fd8afee467ebb0c58909eb673be2f4bfee4c0f9d
      https://github.com/zopefoundation/Acquisition/commit/fd8afee467ebb0c58909eb673be2f4bfee4c0f9d
  Author: Philipp von Weitershausen <philipp at weitershausen.de>
  Date:   2007-07-28 (Sat, 28 Jul 2007)

  Changed paths:
    M _Acquisition.c
    M tests.py

  Log Message:
  -----------
  Make Acquisition.aq_inContextOf aware of __parent__ pointers.


Compare: https://github.com/zopefoundation/Acquisition/compare/3ce7f69c8994^...fd8afee467eb


More information about the checkins mailing list