[Checkins] [zopefoundation/Zope] f1c803: Branch to experiment with adding a REQUEST propert...

[GitHub]

  Branch: refs/heads/elro-remove-request-container
  Home:   https://github.com/zopefoundation/Zope
  Commit: f1c80322ffdef983d66e0026aa1f1aa0a025bd49
      https://github.com/zopefoundation/Zope/commit/f1c80322ffdef983d66e0026aa1f1aa0a025bd49
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-20 (Thu, 20 Jan 2011)

  Log Message:
  -----------
  Branch to experiment with adding a REQUEST property to the application object and remove the request container


  Commit: ff26ad92472eb76c99c669c326bd7212e5ccb6d0
      https://github.com/zopefoundation/Zope/commit/ff26ad92472eb76c99c669c326bd7212e5ccb6d0
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-20 (Thu, 20 Jan 2011)

  Changed paths:
    M setup.py
    M sources.cfg
    M src/OFS/Application.py
    M src/Products/Five/browser/tests/aqlegacy_ftest.txt
    M src/Products/Five/component/makesite.txt
    M src/Testing/ZopeTestCase/base.py
    M src/Testing/ZopeTestCase/connections.py
    M src/Testing/ZopeTestCase/functional.py
    M src/Testing/makerequest.py
    M src/Testing/tests/test_makerequest.py
    M src/ZPublisher/BaseRequest.py
    M src/ZPublisher/Publish.py
    M versions.cfg

  Log Message:
  -----------
  Remove RequestContainer and make app.REQUEST a property looking up the globalrequest.
This mostly works, but causes two problems:
1. Some very old request using Testing.makerequest are unable to clean up the globalrequest after themselves, leading to failures because of lack of test isolation.
2. The Application object itself is no longer aq wrapped, so does not have an aq_explicit attribute.

(Part of http://wiki.zope.org/zope2/SetParentAndNameInOFS)


  Commit: 55567831da25319cc81dc772f4195a2a865f5b79
      https://github.com/zopefoundation/Zope/commit/55567831da25319cc81dc772f4195a2a865f5b79
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-22 (Sat, 22 Jan 2011)

  Changed paths:
    M src/Products/Five/component/makesite.txt

  Log Message:
  -----------
  revert change to makesite.txt


  Commit: ed37538785155b1f0479e0909471b764137670c8
      https://github.com/zopefoundation/Zope/commit/ed37538785155b1f0479e0909471b764137670c8
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-22 (Sat, 22 Jan 2011)

  Changed paths:
    M src/OFS/Application.py

  Log Message:
  -----------
  Add an aq_explicit property to the Application object as it is not longer aq wrapped.


  Commit: 9385ac1f9af0825ae706551722715b8d077e129d
      https://github.com/zopefoundation/Zope/commit/9385ac1f9af0825ae706551722715b8d077e129d
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-22 (Sat, 22 Jan 2011)

  Changed paths:
    M src/Testing/ZopeTestCase/sandbox.py
    M src/Testing/ZopeTestCase/utils.py
    M src/Testing/makerequest.py
    M src/Testing/tests/test_makerequest.py

  Log Message:
  -----------
  revert changes to makerequest, need a different approach here


  Commit: b6c51dede4b84581e8ad653f29c63df3a94d4877
      https://github.com/zopefoundation/Zope/commit/b6c51dede4b84581e8ad653f29c63df3a94d4877
  Author: Laurence Rowe <l at lrowe.co.uk>
  Date:   2011-01-22 (Sat, 22 Jan 2011)

  Changed paths:
    M src/Testing/ZopeTestCase/base.py
    M src/Testing/ZopeTestCase/utils.py
    M src/Testing/makerequest.py

  Log Message:
  -----------
  Leave makerequest using a RequestContainer to support legacy tests; make ZopeTestCase set the global request instead. All tests pass.


Compare: https://github.com/zopefoundation/Zope/compare/f1c80322ffde^...b6c51dede4b8