[Checkins] [zopefoundation/zodbpickle] a2a85d: Include all the tests in the test suite

GitHub noreply at github.com
Mon Mar 4 13:52:53 UTC 2013


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/zodbpickle
  Commit: a2a85dad3158d39bd3056647984a034d7df4545e
      https://github.com/zopefoundation/zodbpickle/commit/a2a85dad3158d39bd3056647984a034d7df4545e
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2013-03-04 (Mon, 04 Mar 2013)

  Changed paths:
    M setup.py
    M src/zodbpickle/tests/pickletester.py
    M src/zodbpickle/tests/test_pickle.py

  Log Message:
  -----------
  Include all the tests in the test suite

Previously we had no test_suite function and so automatic test discovery
kind of worked.  But it skipped the two doctests and a bunch of other
tests from test classes that forgot to subclass unittest.TestCase.

This uncovered some test failures under Python 3.2 that were not noticed
because those test cases were accidentally not being run.

Here I tried to minimize the differences from stdlib's test_pickle.py
and pickeltester.py: all abstract test classes inherit from
unittest.TestCase again, but only explicitly enumerated test classes
that comprise the test_suite() function will be run by the test runner.

I also removed an incorrect PyPicklerBase base class that caused
PyPicklerBytestrTests and PyPicklerBytesFallbackTests to repeat all the
PyPicklerTests unnecessarily.





More information about the checkins mailing list