[Checkins] [zopefoundation/zope.app.component] 051228: Assert location for all adapters that require any ...

GitHub noreply at github.com
Tue Mar 12 13:23:57 UTC 2013


  Branch: refs/heads/monolithic-zope3-dominik-locatableadapters
  Home:   https://github.com/zopefoundation/zope.app.component
  Commit: 051228f099598b96aeca2a7741fcd0a482b06a00
      https://github.com/zopefoundation/zope.app.component/commit/051228f099598b96aeca2a7741fcd0a482b06a00
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-14 (Thu, 14 Apr 2005)

  Changed paths:
    A metaconfigure.py
    A tests/test_directives.py

  Log Message:
  -----------
  Assert location for all adapters that require any dedicated permission:

If the permission attribute is used in the adapter directive and the permission is not zope.Public, then:

    If the adapter doesn't provide ILocation, we location 
    proxy it and set the parent.

    If the adapter does provide ILocation and it's __parent__
    is None, we set the __parent__. 

TODO:
I do not unterstand three tests inside zope.app.component.tests.test_directives.

I've got pickable errors within zope.app.intid's
functional tests. As a workaround I derive
zope.app.keyreference.persistent.KeyReferenceToPersistent
from location.

I marked those issues with
# TODO: I do not understand that test


  Commit: 295c0615a55f6661f5a3e82bbaaaea65b1a9d46d
      https://github.com/zopefoundation/zope.app.component/commit/295c0615a55f6661f5a3e82bbaaaea65b1a9d46d
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-14 (Thu, 14 Apr 2005)

  Changed paths:
    M metaconfigure.py

  Log Message:
  -----------
  cosmetics

TODO:
- refactor subscriber directive too


  Commit: 73adcd5d4bd731fb39cc71d704fbb3a3a66248ac
      https://github.com/zopefoundation/zope.app.component/commit/73adcd5d4bd731fb39cc71d704fbb3a3a66248ac
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-15 (Fri, 15 Apr 2005)

  Changed paths:
    M metaconfigure.py

  Log Message:
  -----------
  fix cosmetics mischance

TODO:
- refactor subscriber directive too
- write more tests for adapter and subsriber directive


  Commit: 55f6c35981b3bfae7d51872faebc8c28cc25e7f9
      https://github.com/zopefoundation/zope.app.component/commit/55f6c35981b3bfae7d51872faebc8c28cc25e7f9
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-20 (Wed, 20 Apr 2005)

  Changed paths:
    M metaconfigure.py
    M tests/test_directives.py

  Log Message:
  -----------
  revert keyrefence and intid changes
add additional locating trusted adapter factory

todo:
- how to handle null adapters?
- implementation is pretty implicit


  Commit: a85bf1203a67aad0f5fae742ff729146ad3b288b
      https://github.com/zopefoundation/zope.app.component/commit/a85bf1203a67aad0f5fae742ff729146ad3b288b
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-20 (Wed, 20 Apr 2005)

  Changed paths:
    M metaconfigure.py
    M tests/test_directives.py

  Log Message:
  -----------
  revert to the first implementation concept:

trusted adapters provide always a location.

untrusted adapters provide a location unless
its factories are public.

if an adapter does not provide ILocation itself
it gets location-proxied. such an adapter is
not directly pickable because location proxies
are not pickable. if you use pickalbe adapters
they should provide ILocation.


  Commit: 8653393a95c61957468efb62893a835667efbd5c
      https://github.com/zopefoundation/zope.app.component/commit/8653393a95c61957468efb62893a835667efbd5c
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-20 (Wed, 20 Apr 2005)

  Changed paths:
    M metaconfigure.py
    M tests/test_directives.py

  Log Message:
  -----------
  change subsriber directive too.


  Commit: 0572c02bed3f7b82c9796a1cb94bdd938778b393
      https://github.com/zopefoundation/zope.app.component/commit/0572c02bed3f7b82c9796a1cb94bdd938778b393
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-04-20 (Wed, 20 Apr 2005)

  Changed paths:
    M metaconfigure.py
    M tests/test_directives.py

  Log Message:
  -----------
  Only use a location proxy if the trusted adapter is protected and does not provide ILocation.


  Commit: eea9d2cc2ba6496ae20ad97281dd76c9cbbe277e
      https://github.com/zopefoundation/zope.app.component/commit/eea9d2cc2ba6496ae20ad97281dd76c9cbbe277e
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-05-02 (Mon, 02 May 2005)

  Changed paths:
    A browser/registration.py
    A interface.py

  Log Message:
  -----------
  merge trunk into branch (from 29979 to 30223)


  Commit: 042d6b333b8064920b3b5e084f92b2cf84048039
      https://github.com/zopefoundation/zope.app.component/commit/042d6b333b8064920b3b5e084f92b2cf84048039
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-05-02 (Mon, 02 May 2005)

  Changed paths:
    M metaconfigure.py

  Log Message:
  -----------
  clean up code:
- remove unused classes
- move tests to adapter.txt


  Commit: cfa0b2ad7f62dfa7eb619521f4ab1f0a19ead1ae
      https://github.com/zopefoundation/zope.app.component/commit/cfa0b2ad7f62dfa7eb619521f4ab1f0a19ead1ae
  Author: Dominik Huber <dominik.huber at ideell.ch>
  Date:   2005-05-19 (Thu, 19 May 2005)

  Changed paths:
    M metaconfigure.py
    A metadirectives.py
    M tests/test_directives.py

  Log Message:
  -----------
  extend adapter directive with a locate attribute


Compare: https://github.com/zopefoundation/zope.app.component/compare/051228f09959^...cfa0b2ad7f62


More information about the checkins mailing list