[Checkins] [zopefoundation/zope.testbrowser] ef5011: Fix newline stripping logic with WebTest 2.0.6

GitHub noreply at github.com
Thu Sep 12 10:08:50 CEST 2013


  Branch: refs/heads/py3
  Home:   https://github.com/zopefoundation/zope.testbrowser
  Commit: ef501138132e33e724c5957fcafee31414cafd5a
      https://github.com/zopefoundation/zope.testbrowser/commit/ef501138132e33e724c5957fcafee31414cafd5a
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2013-09-12 (Thu, 12 Sep 2013)

  Changed paths:
    M setup.py
    M src/zope/testbrowser/browser.py
    M tox.ini

  Log Message:
  -----------
  Fix newline stripping logic with WebTest 2.0.6

Background:

- Browsers strip the first newline and only the first newline from the
  contents of a <textarea> element.

- zope.testbrowser wants to mimic a real browser in this respect
  (https://bugs.launchpad.net/zope3/+bug/98371)

- WebTest 2.0.5 didn't strip the first newline, so zope.testbrowser had
  to do the stripping by itself.

- WebTest 2.0.6 started stripping the first newline
  (https://github.com/Pylons/webtest/pull/69)

Problem:

- this broke zope.testbrowser

Solution:

- require WebTest >= 2.0.6

- do not strip any newlines, expect WebTest to do that for us





More information about the checkins mailing list