[Checkins] [zopefoundation/persistent] d4d596: Fix Python timestamp hash on 64-bit windows

GitHub noreply at github.com
Mon Dec 19 17:47:03 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/persistent
  Commit: d4d59673ca74f1c3f0ff03c8f5bdf0c188f9d3e1
      https://github.com/zopefoundation/persistent/commit/d4d59673ca74f1c3f0ff03c8f5bdf0c188f9d3e1
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M persistent/tests/test_timestamp.py
    M persistent/timestamp.py

  Log Message:
  -----------
  Fix Python timestamp hash on 64-bit windows

Fixes #51

Part of the problem was in the tests. The detection of when the hash
gets truncated was broken on win32.

Part of the problem is somewhere in the _wraparound function, I think,
because even fixing the tests to use the right values we still get
mismatches. Rather than dig into that, I just go back to using ctypes
when it's available.


  Commit: 358cd618a198270f13d27430049a34f5d62ffddf
      https://github.com/zopefoundation/persistent/commit/358cd618a198270f13d27430049a34f5d62ffddf
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M CHANGES.rst
    M persistent/tests/test_timestamp.py
    M persistent/timestamp.py

  Log Message:
  -----------
  Fix _wraparound on 64-bit windows without using ctypes.


  Commit: 8de39e618c3df32b6ca5c584eeb393e23d7e7c00
      https://github.com/zopefoundation/persistent/commit/8de39e618c3df32b6ca5c584eeb393e23d7e7c00
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M CHANGES.rst
    M persistent/tests/test_timestamp.py
    M persistent/timestamp.py

  Log Message:
  -----------
  Revert "Fix _wraparound on 64-bit windows without using ctypes."

This reverts commit 358cd618a198270f13d27430049a34f5d62ffddf.

The _wraparound function is still broken on PyPy3 (both the old version
on Travis and the latest available) if we don't use ctypes.


  Commit: c6be5f8f03ff6d3f71c0dbefe546ba6ab5cc4c5f
      https://github.com/zopefoundation/persistent/commit/c6be5f8f03ff6d3f71c0dbefe546ba6ab5cc4c5f
  Author: Jason Madden <jason+github at nextthought.com>
  Date:   2016-12-19 (Mon, 19 Dec 2016)

  Changed paths:
    M CHANGES.rst
    M persistent/tests/test_timestamp.py
    M persistent/timestamp.py

  Log Message:
  -----------
  Merge pull request #55 from zopefoundation/fix-64bit-win

Fix Python timestamp hash on 64-bit windows


Compare: https://github.com/zopefoundation/persistent/compare/be61b91bda79...c6be5f8f03ff


More information about the checkins mailing list