[Checkins] [zopefoundation/persistent] f98da9: Stop calling gc.collect in the Python incrgc.

GitHub noreply at github.com
Tue Dec 20 16:29:16 CET 2016


  Branch: refs/heads/disable-incrgc-gc
  Home:   https://github.com/zopefoundation/persistent
  Commit: f98da971f43c73c5753ebdc8977962c5be4acd3e
      https://github.com/zopefoundation/persistent/commit/f98da971f43c73c5753ebdc8977962c5be4acd3e
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M CHANGES.rst
    M persistent/picklecache.py
    M persistent/tests/test_picklecache.py

  Log Message:
  -----------
  Stop calling gc.collect in the Python incrgc.

@jimfulton and I have talked about it, and I'm (mostly :) convinced that
this shouldn't be an actual problem for any of the reasons described in
the previous comment.

If I use PyPy 5.4.1 to run the ZODB master test suite against
this (well, with #44 rolled back) I don't get any unexpected
failures. (I haven't run the ZEO test suite yet.) Which honestly amazes
me because I'm sure I used to get test failures---I guess the PyPy GC
has changed...which means we may see some failures on Travis. I'll try
to set up an older PyPy to verify.


  Commit: 0821b4d1ea95dc9a7af10bf20bb50fabbe86f20d
      https://github.com/zopefoundation/persistent/commit/0821b4d1ea95dc9a7af10bf20bb50fabbe86f20d
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-12-20 (Tue, 20 Dec 2016)

  Changed paths:
    M CHANGES.rst

  Log Message:
  -----------
  move change note; rebased on master


Compare: https://github.com/zopefoundation/persistent/compare/8a09a433d19b...0821b4d1ea95


More information about the checkins mailing list