[Checkins] [zopefoundation/zope.publisher] 85c700: Redo decoding

GitHub noreply at github.com
Sat Nov 5 02:29:55 CET 2016


  Branch: refs/heads/fix-decoding
  Home:   https://github.com/zopefoundation/zope.publisher
  Commit: 85c7000cddbb0e991dd75328cf46d9cfebc97c45
      https://github.com/zopefoundation/zope.publisher/commit/85c7000cddbb0e991dd75328cf46d9cfebc97c45
  Author: Brian Sutherland <brian at vanguardistas.net>
  Date:   2016-11-05 (Sat, 05 Nov 2016)

  Changed paths:
    M src/zope/publisher/browser.py
    M src/zope/publisher/tests/test_browserrequest.py

  Log Message:
  -----------
  Redo decoding

Recode QUERY_STRING earlier rather than encoding
after it has passed through FieldStorage. We were
erroneously encoding form data from the body :(

Also, note that on python3 cgi.FieldStorage already
decodes using utf-8, so either just return that or
encode to bytes to we can later decode.

This code is particularly insane, but almost
impossible to fix properly without vendoring
FieldStorage which started decoding it’s inputs
in python3 :(




More information about the checkins mailing list