[Checkins] [zopefoundation/persistent] 8a09a4: Stop calling gc.collect in the Python incrgc.

GitHub noreply at github.com
Fri Oct 28 00:43:43 CEST 2016


  Branch: refs/heads/disable-incrgc-gc
  Home:   https://github.com/zopefoundation/persistent
  Commit: 8a09a433d19ba9571c60411ddd1be34d29a89d5d
      https://github.com/zopefoundation/persistent/commit/8a09a433d19ba9571c60411ddd1be34d29a89d5d
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2016-10-27 (Thu, 27 Oct 2016)

  Changed paths:
    M CHANGES.rst
    M persistent/picklecache.py
    M persistent/tests/test_picklecache.py

  Log Message:
  -----------
  Stop calling gc.collect in the Python incrgc.

@jimfulton and I have talked about it, and I'm (mostly :) convinced that
this shouldn't be an actual problem for any of the reasons described in
the previous comment.

If I use PyPy 5.4.1 to run the ZODB master test suite against
this (well, with #44 rolled back) I don't get any unexpected
failures. (I haven't run the ZEO test suite yet.) Which honestly amazes
me because I'm sure I used to get test failures---I guess the PyPy GC
has changed...which means we may see some failures on Travis. I'll try
to set up an older PyPy to verify.




More information about the checkins mailing list