[Checkins] [zopefoundation/ZODB] 30bbab: FileStorage: Report problem on read-only open of n...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/ZODB
  Commit: 30bbabf19e837b4ca9e35fab5d5c1278b078fe45
      https://github.com/zopefoundation/ZODB/commit/30bbabf19e837b4ca9e35fab5d5c1278b078fe45
  Author: Kirill Smelkov <kirr at nexedi.com>
  Date:   2017-04-02 (Sun, 02 Apr 2017)

  Changed paths:
    M src/ZODB/FileStorage/FileStorage.py
    M src/ZODB/tests/testConfig.py
    M src/ZODB/tests/testFileStorage.py

  Log Message:
  -----------
  FileStorage: Report problem on read-only open of non-existent file

... instead of silently creating empty database on such opens.

Use-case for this are utilities like e.g. zodbdump and zodbcmp which
expect such storage opens to fail so that the tool can know there is no
such storage and report it to user.

In contrast current state is: read-only opens get created-on-the-fly
empty storage with no content, but which can be iterated over without
getting any error.

This way e.g. `zodbdump non-existent.fs` produces empty output _and_
exit code 0 which is not what caller expects.


  Commit: 4fa93367e2efd55a82f83252fd9fb87f42c12e1d
      https://github.com/zopefoundation/ZODB/commit/4fa93367e2efd55a82f83252fd9fb87f42c12e1d
  Author: Jim Fulton <jim at jimfulton.info>
  Date:   2017-04-02 (Sun, 02 Apr 2017)

  Changed paths:
    M src/ZODB/FileStorage/FileStorage.py
    M src/ZODB/tests/testConfig.py
    M src/ZODB/tests/testFileStorage.py

  Log Message:
  -----------
  Merge pull request #153 from navytux/y/fs-ro

FileStorage: Report problem on read-only open of non-existent file


Compare: https://github.com/zopefoundation/ZODB/compare/3a8efe47f9dc...4fa93367e2ef