[Checkins] [zopefoundation/zope.container] 1e834e: 100% coverage for _proxy.py.

[GitHub]

  Branch: refs/heads/coverage
  Home:   https://github.com/zopefoundation/zope.container
  Commit: 1e834e7315ae05fc09eeb7702ad289c7d2c2cc0d
      https://github.com/zopefoundation/zope.container/commit/1e834e7315ae05fc09eeb7702ad289c7d2c2cc0d
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/contained.py
    M src/zope/container/tests/test_contained.py

  Log Message:
  -----------
  100% coverage for _proxy.py.

Also convert test_contained.py doctests to real tests for ease of addition and debugging #13.


  Commit: bda1ad2929146239b1aeb263f0f5a76a4e1bcb60
      https://github.com/zopefoundation/zope.container/commit/bda1ad2929146239b1aeb263f0f5a76a4e1bcb60
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_icontainer.py

  Log Message:
  -----------
  100% coverage of test_icontainer.py

Also cleanups:

- Replace self.assertEqual(not not foo in container, True) with
  equivalent self.assertIn(foo, container) form.
- Whitespace.
- Let a ValueError propagate instead of failing because the error is
  clearer.


  Commit: bffbb130114ea6baaf6871f5db4219a438e26a3d
      https://github.com/zopefoundation/zope.container/commit/bffbb130114ea6baaf6871f5db4219a438e26a3d
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_btree.py

  Log Message:
  -----------
  100% coverage and minor cleanups of test_btree


  Commit: 4ca4e05b0135b5cd7a53af9430a464bbe39c21e2
      https://github.com/zopefoundation/zope.container/commit/4ca4e05b0135b5cd7a53af9430a464bbe39c21e2
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_size.py

  Log Message:
  -----------
  100% coverage and minor cleanups of test_size


  Commit: f78b8aadcfaf99749dc0cefca4e974053d0dd77b
      https://github.com/zopefoundation/zope.container/commit/f78b8aadcfaf99749dc0cefca4e974053d0dd77b
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M .coveragerc
    M src/zope/container/tests/test_find.py

  Log Message:
  -----------
  100% coverage for find.py/test_find.py


  Commit: df304d682b427c2c269dc6b8979fda0f7a2cc740
      https://github.com/zopefoundation/zope.container/commit/df304d682b427c2c269dc6b8979fda0f7a2cc740
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_icontainer.py

  Log Message:
  -----------
  100% coverage for sample.py


  Commit: ff79491edae3c7c48b9fbb7a2168ff5e2879211b
      https://github.com/zopefoundation/zope.container/commit/ff79491edae3c7c48b9fbb7a2168ff5e2879211b
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_btree.py

  Log Message:
  -----------
  100% coverage for btree.py


  Commit: 88a095b60673dfcbcb0be4eedb0b26e5d431d577
      https://github.com/zopefoundation/zope.container/commit/88a095b60673dfcbcb0be4eedb0b26e5d431d577
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_directory.py

  Log Message:
  -----------
  100% coverage and minor cleanups for test_directory.py


  Commit: 86e9147038005fefde934c17adcc60754288af36
      https://github.com/zopefoundation/zope.container/commit/86e9147038005fefde934c17adcc60754288af36
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/constraints.py
    M src/zope/container/tests/test_constraints.py
    M src/zope/container/tests/test_containertraversable.py

  Log Message:
  -----------
  100% coverage for constraints.py

- Whitespace cleanup
- Remove useless else after a for with no break
- Replace `if thing is not None: try: thing.foo except AttributeError`
  with simpler pattern of just the try/except. This benchmarks faster
  for the common case that the attribute is present on Python 2.7 and
  3.5 and about the same on PyPy. (Common case determined by the test
  cases: none of them were hitting the AttributeError inside the if
  test.)  If the object really is None, it's somewhat slower on
  3.5/3.6 (590ns vs 101ns), about 5x slower on Python 2.7 (1.4us vs
  250ns), and roughly a wash on PyPy.


  Commit: d8a81bc5e8d26a90e92c18220f3d9aba78df5b24
      https://github.com/zopefoundation/zope.container/commit/d8a81bc5e8d26a90e92c18220f3d9aba78df5b24
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/ordered.py

  Log Message:
  -----------
  100% coverage for ordered.py

But note this exposes a bug: https://github.com/zopefoundation/zope.container/issues/17


  Commit: 1c484d6d11e7bb0794a09d28c73aae137abf9dd7
      https://github.com/zopefoundation/zope.container/commit/1c484d6d11e7bb0794a09d28c73aae137abf9dd7
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/ordered.py
    M src/zope/container/tests/test_ordered.py

  Log Message:
  -----------
  Convert test_ordered doctests to unittest. This uncovered https://github.com/zopefoundation/zope.container/issues/18 which remains unfixed.


  Commit: d50709d5566b8c68d6a2c7abaf571be973bc80fe
      https://github.com/zopefoundation/zope.container/commit/d50709d5566b8c68d6a2c7abaf571be973bc80fe
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M CHANGES.rst
    M src/zope/container/ordered.py
    M src/zope/container/tests/test_icontainer.py
    M src/zope/container/tests/test_ordered.py

  Log Message:
  -----------
  Fix #17 and fix #18

Add tests to the shared test base for these and make sure ordered
container runs them.


  Commit: beec4f2bf86e11b809cc21b85bda8df21fb9929b
      https://github.com/zopefoundation/zope.container/commit/beec4f2bf86e11b809cc21b85bda8df21fb9929b
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/test_contained_zodb.py

  Log Message:
  -----------
  100% coverage for test_contained_zodb

Convert doctests to real tests to verify this.


  Commit: c7ef428324050fc3c4a9c8863aa90fbc6fd6b5cc
      https://github.com/zopefoundation/zope.container/commit/c7ef428324050fc3c4a9c8863aa90fbc6fd6b5cc
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/tests/directory.rst
    M src/zope/container/tests/test_directory.py

  Log Message:
  -----------
  100% coverage for directory.py


  Commit: 3991c5c7b59846d0e9d44d00b89f61c136200ee6
      https://github.com/zopefoundation/zope.container/commit/3991c5c7b59846d0e9d44d00b89f61c136200ee6
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/contained.py
    M src/zope/container/tests/test_contained.py

  Log Message:
  -----------
  Coverage for contained.py


  Commit: fb2c8161020534052ff85d40975aa46175558e2a
      https://github.com/zopefoundation/zope.container/commit/fb2c8161020534052ff85d40975aa46175558e2a
  Author: Jason Madden <jamadden at gmail.com>
  Date:   2017-07-27 (Thu, 27 Jul 2017)

  Changed paths:
    M src/zope/container/contained.py
    M src/zope/container/tests/test_contained.py
    M src/zope/container/tests/test_containertraversable.py
    M src/zope/container/tests/test_containertraverser.py

  Log Message:
  -----------
  100% coverage for traversal.


Compare: https://github.com/zopefoundation/zope.container/compare/1e834e7315ae^...fb2c81610205