[Checkins] [zopefoundation/Zope] 338f6d: SiteAccess: Make VirtualHostMonster support IPv6 (...

[GitHub]

  Branch: refs/heads/2.13
  Home:   https://github.com/zopefoundation/Zope
  Commit: 338f6d07f9df6749eb9a5f65e5032e5919caf839
      https://github.com/zopefoundation/Zope/commit/338f6d07f9df6749eb9a5f65e5032e5919caf839
  Author: Łukasz Nowak <lukasz at nowak.io>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M src/Products/SiteAccess/VirtualHostMonster.py
    M src/Products/SiteAccess/tests/testVirtualHostMonster.py

  Log Message:
  -----------
  SiteAccess: Make VirtualHostMonster support IPv6 (#314)

from https://bugs.launchpad.net/zope2/+bug/699865 :

VirtualHostMonster does not work with IPv6 named hosts.

In case of such rewrite configuration:

RewriteRule (.*) http://10.0.243.129:9280/VirtualHostBase/https/[%{SERVER_ADDR}]:4080$1 [L,P]

When SERVER_ADDR is fd00::74ba VirtualHostMonster dies with:

Traceback (most recent call last):
  File "/eggs/Zope2-2.12.14-py2.6-linux-x86_64.egg/ZPublisher/BeforeTraverse.py", line 145, in __call__
    meth(*(container, request, None)[:args])
  File "/eggs/Zope2-2.12.14-py2.6-linux-x86_64.egg/Products/SiteAccess/VirtualHostMonster.py", line 154, in __call__
    host, port = host.split(':')
ValueError: too many values to unpack

This is because IPv6 addresses contain ":" in them.

--
This is backport of https://github.com/zopefoundation/Zope/pull/314 to
2.13 branch

This also include part of:
2e9d01ea2b3ac0bac2e59dd06e070dd34329a4fe - flake8 Products/Shared/ZTUtils.
removing test_suite function from the test


  Commit: 6fbaee13f4054ba4038d45359c59e01d24831cc4
      https://github.com/zopefoundation/Zope/commit/6fbaee13f4054ba4038d45359c59e01d24831cc4
  Author: Michael Howitz <mh at gocept.com>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M src/Products/SiteAccess/tests/testVirtualHostMonster.py

  Log Message:
  -----------
  Fix indentation and add actual IPv4 tests from master.


  Commit: b7046ffb9fbd9c109310d275da04157896d9e68a
      https://github.com/zopefoundation/Zope/commit/b7046ffb9fbd9c109310d275da04157896d9e68a
  Author: Jérome Perrin <perrinjerome at gmail.com>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M src/Products/SiteAccess/VirtualHostMonster.py
    M src/Products/SiteAccess/tests/testVirtualHostMonster.py

  Log Message:
  -----------
  Merge pull request #395 from perrinjerome/backport/314

Zope 2.13: SiteAccess: Make VirtualHostMonster support IPv6


Compare: https://github.com/zopefoundation/Zope/compare/0c4b5d6cf17f...b7046ffb9fbd
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.