[Checkins] [zopefoundation/Zope] b410c8: SiteAccess: Make VirtualHostMonster support IPv6 (...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/Zope
  Commit: b410c824ee33fd9c1dff0321827fd03720b274d0
      https://github.com/zopefoundation/Zope/commit/b410c824ee33fd9c1dff0321827fd03720b274d0
  Author: Łukasz Nowak <lukasz at nowak.io>
  Date:   2018-10-17 (Wed, 17 Oct 2018)

  Changed paths:
    M src/Products/SiteAccess/VirtualHostMonster.py
    M src/Products/SiteAccess/tests/testVirtualHostMonster.py

  Log Message:
  -----------
  SiteAccess: Make VirtualHostMonster support IPv6 (#314)

from https://bugs.launchpad.net/zope2/+bug/699865 :

VirtualHostMonster does not work with IPv6 named hosts.

In case of such rewrite configuration:

RewriteRule (.*) http://10.0.243.129:9280/VirtualHostBase/https/[%{SERVER_ADDR}]:4080$1 [L,P]

When SERVER_ADDR is fd00::74ba VirtualHostMonster dies with:

Traceback (most recent call last):
  File "/eggs/Zope2-2.12.14-py2.6-linux-x86_64.egg/ZPublisher/BeforeTraverse.py", line 145, in __call__
    meth(*(container, request, None)[:args])
  File "/eggs/Zope2-2.12.14-py2.6-linux-x86_64.egg/Products/SiteAccess/VirtualHostMonster.py", line 154, in __call__
    host, port = host.split(':')
ValueError: too many values to unpack

This is because IPv6 addresses contain ":" in them.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.