[Checkins] [zopefoundation/zope.security] 4fc05a: Fix comparison for classes implementing __eq__.

Michael Howitz noreply at github.com
Tue Apr 2 21:26:49 CEST 2019


  Branch: refs/heads/issue-50
  Home:   https://github.com/zopefoundation/zope.security
  Commit: 4fc05a11233e6a66fa6467b9703e2526ac66eb8c
      https://github.com/zopefoundation/zope.security/commit/4fc05a11233e6a66fa6467b9703e2526ac66eb8c
  Author: Michael Howitz <mh at gocept.com>
  Date:   2019-04-02 (Tue, 02 Apr 2019)

  Changed paths:
    M src/zope/security/tests/test_proxy.py

  Log Message:
  -----------
  Fix comparison for classes implementing __eq__.

There are currently only two new failing tests:

* Comparing an object with a proxy of the object fails (but comparing the proxy with the object is fine!)
* Comparing a proxy with itself fails

But these tests run fine when deleting the `__eq__` method on the `Something` class which is the class of `self.x`.


  Commit: 7684a5f5490cd4fb58c93097ec663c6d8352e138
      https://github.com/zopefoundation/zope.security/commit/7684a5f5490cd4fb58c93097ec663c6d8352e138
  Author: Michael Howitz <mh at gocept.com>
  Date:   2019-04-02 (Tue, 02 Apr 2019)

  Changed paths:
    M src/zope/security/_proxy.c
    M src/zope/security/tests/test_proxy.py

  Log Message:
  -----------
  Unwrap other if it is a proxy, so the proxy can compare equal to itself.


Compare: https://github.com/zopefoundation/zope.security/compare/4d089ffafade...7684a5f5490c


More information about the checkins mailing list