[Checkins] [zopefoundation/persistent] bae156: Fix C compilation warning

Marius Gedminas noreply at github.com
Thu Apr 25 17:21:12 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/zopefoundation/persistent
  Commit: bae1560d52dba696fdedc68985cadc680ac11862
      https://github.com/zopefoundation/persistent/commit/bae1560d52dba696fdedc68985cadc680ac11862
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Fix C compilation warning

gcc 8.3.0 emits this during python setup.py build:

persistent/cPersistence.c: In function ‘Per_repr’:
persistent/cPersistence.c:1481:44: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘uint64_t’ {aka ‘long unsigned int’} [-Wformat=]
         snprintf(buf, sizeof(buf) - 1, "%llx", oid_value);
                                         ~~~^   ~~~~~~~~~
                                         %lx

<stdint.h> defines standard macros such as PRId64, PRIu64 and PRIx64 for
printing {u,}int64_t values, so let's use them.


  Commit: 19661a9eea60168d6fcf12df0b122a22a573a6a8
      https://github.com/zopefoundation/persistent/commit/19661a9eea60168d6fcf12df0b122a22a573a6a8
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Why does Microsoft even exist?


  Commit: 101d1eda55585d262ebe17b1146abd67e93d506b
      https://github.com/zopefoundation/persistent/commit/101d1eda55585d262ebe17b1146abd67e93d506b
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M persistent/cPersistence.c

  Log Message:
  -----------
  Oh, actually it was my mistake

PRIx64 is defined in <inttypes.h>, not <stdint.h>.

I hate C.


  Commit: 700d25cff063c539dc0af6ec5b1dc1cdd325d423
      https://github.com/zopefoundation/persistent/commit/700d25cff063c539dc0af6ec5b1dc1cdd325d423
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M .manylinux-install.sh
    M .travis.yml
    M CHANGES.rst
    M appveyor.yml
    M setup.py
    M tox.ini

  Log Message:
  -----------
  Drop Python 3.4 support


  Commit: 3e0f98d6bd44f15fb2f149d52f076fb3256a2ff4
      https://github.com/zopefoundation/persistent/commit/3e0f98d6bd44f15fb2f149d52f076fb3256a2ff4
  Author: Marius Gedminas <marius at gedmin.as>
  Date:   2019-04-25 (Thu, 25 Apr 2019)

  Changed paths:
    M .manylinux-install.sh
    M .travis.yml
    M CHANGES.rst
    M appveyor.yml
    M persistent/cPersistence.c
    M setup.py
    M tox.ini

  Log Message:
  -----------
  Merge pull request #111 from zopefoundation/fix-c-warning

Fix C compilation warning


Compare: https://github.com/zopefoundation/persistent/compare/dc2283d86922...3e0f98d6bd44


More information about the checkins mailing list